Bug 160597 - [patch] audio/xmp: enable --realtime command line option
Summary: [patch] audio/xmp: enable --realtime command line option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 20:40 UTC by h h
Modified: 2011-09-15 20:10 UTC (History)
0 users

See Also:


Attachments
a.diff (676 bytes, patch)
2011-09-09 20:40 UTC, h h
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description h h 2011-09-09 20:40:14 UTC
Autodetection of <sys/rtprio.h> presence fails due to missing typedefs
provided by <sys/types.h>. And rtprio(2) manpage mentions both.

From docs/ChangeLog:

  1.1.6 (19981019):
        - Option for realtime priority in FreeBSD added by Douglas
          Carmichael <dcarmich@mcs.com>

Apparently, autoconf-2.12 (in xmp-1.1.6) only checks headers with CPP but
autoconf-2.67 (in xmp-3.4.1) also tries to compile them with CC and fails.

cf. http://sourceforge.net/mailarchive/forum.php?thread_name=86ty8zcut0.fsf%40gmail.com&forum_name=xmp-devel

How-To-Repeat: $ gcc -S -xc -include sys/types.h -include sys/rtprio.h /dev/null -o /dev/null
$ gcc -S -xc -include sys/rtprio.h /dev/null -o /dev/null
In file included from /usr/include/sys/rtprio.h:37,
                 from <command-line>:0:
/usr/include/sys/priority.h:127: error: expected specifier-qualifier-list before 'u_char'
In file included from <command-line>:0:
/usr/include/sys/rtprio.h:73: error: expected specifier-qualifier-list before 'u_short'
In file included from <command-line>:0:
/usr/include/sys/rtprio.h:88: error: expected declaration specifiers or '...' before 'pid_t'
/usr/include/sys/rtprio.h:89: error: expected declaration specifiers or '...' before 'lwpid_t'
Exit 1

$ clang -S -xc -include sys/types.h -include sys/rtprio.h /dev/null -o /dev/null
$ clang -S -xc -include sys/rtprio.h /dev/null -o /dev/null
In file included from <built-in>:130:
In file included from <command line>:1:
In file included from /usr/include/sys/rtprio.h:37:
/usr/include/sys/priority.h:127:2: error: unknown type name 'u_char'; did you mean 'char'?
        u_char  pri_class;      /* Scheduling class. */
        ^
/usr/include/sys/priority.h:128:2: error: unknown type name 'u_char'; did you mean 'char'?
        u_char  pri_level;      /* Normal priority level. */
        ^
/usr/include/sys/priority.h:129:2: error: unknown type name 'u_char'; did you mean 'char'?
        u_char  pri_native;     /* Priority before propogation. */
        ^
/usr/include/sys/priority.h:130:2: error: unknown type name 'u_char'; did you mean 'char'?
        u_char  pri_user;       /* User priority based on p_cpu and p_nice. */
        ^
In file included from <built-in>:130:
In file included from <command line>:1:
/usr/include/sys/rtprio.h:73:2: error: unknown type name 'u_short'; did you mean 'short'?
        u_short type;                   /* scheduling class */
        ^
/usr/include/sys/rtprio.h:74:2: error: unknown type name 'u_short'; did you mean 'short'?
        u_short prio;
        ^
6 errors generated.
Exit 1

$ make configure
[...]
checking sys/rtprio.h usability... no
checking sys/rtprio.h presence... yes
configure: WARNING: sys/rtprio.h: present but cannot be compiled
configure: WARNING: sys/rtprio.h:     check for missing prerequisite headers?
configure: WARNING: sys/rtprio.h: see the Autoconf documentation
configure: WARNING: sys/rtprio.h:     section "Present But Cannot Be Compiled"
configure: WARNING: sys/rtprio.h: proceeding with the compiler's result
checking for sys/rtprio.h... no
[...]
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-09 20:40:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-09-10 10:56:39 UTC
ehaupt      2011-09-10 09:56:31 UTC

  FreeBSD ports repository

  Modified files:
    audio/xmp            Makefile 
  Added files:
    audio/xmp/files      patch-audio__xmp__files__patch-configure 
  Log:
  Fix autodetection of <sys/rtprio.h> which currently fails due to missing
  typedefs provided by <sys/types.h>.
  
  PR:             160597
  Submitted by:   aakuusta@gmail.com
  
  Revision  Changes    Path
  1.56      +1 -0      ports/audio/xmp/Makefile
  1.1       +14 -0     ports/audio/xmp/files/patch-audio__xmp__files__patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2011-09-10 10:56:42 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-09-15 20:03:35 UTC
crees       2011-09-15 19:03:25 UTC

  FreeBSD ports repository

  Added files:
    audio/xmp/files      patch-configure 
  Removed files:
    audio/xmp/files      patch-audio__xmp__files__patch-configure 
  Log:
  Previous commit was the actual patch from the PR in files/ -- this time actually
  apply the patch.
  
  PR:             ports/160597
  Submitted by:   h h <aakuusta@gmail.com>
  
  Revision  Changes    Path
  1.2       +0 -14     ports/audio/xmp/files/patch-audio__xmp__files__patch-configure (dead)
  1.1       +17 -0     ports/audio/xmp/files/patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"