Building of the fusefs-kmod port failed in fuse_modules/fuse_vfsops.c due to an incorrect typing of the third argument of calls to vfs_flagopt. It the variables 'mntopts and __mntopts are declared to be int when vfs_flagopt expects uint64_t. fuse_vfsops.c: In function 'fuse_mount': fuse_vfsops.c:339: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:339: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:340: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:340: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:341: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:341: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:342: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:342: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:343: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type fuse_vfsops.c:343: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type Proposed fix may not be correct, but it did allow the port to build. Perhaps a cast would have been the right answer. How-To-Repeat: cd /usr/ports/sysutils/fusefs-kmod && make
Maintainer of sysutils/fusefs-kmod, Please note that PR ports/160608 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160608 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
This problem report is a duplicate http://www.freebsd.org/cgi/query-pr.cgi?pr=159361&cat=
On Fri, Sep 9, 2011 at 11:34 PM, Ivan Klymenko <fidaj@ukr.net> wrote: > This problem report is a duplicate > http://www.freebsd.org/cgi/query-pr.cgi?pr=159361&cat= PR ports/159361 is a bit of a mess as it conflates two PRa related to the fusefs-kmod port. The long patch in the PR is mostly changes that are already committed to the port. Only a single change, from 'int' to 'uint64_t' in the third hunk is required, as far as I can tell. It changes three variables from 'int' to 'uint64_t', where mine only changed the first two, but I can't say which is more correct and it may make no difference. Please don't assume that the committed patch is the complete fix. -- R. Kevin Oberman, Network Engineer - Retired E-mail: kob6558@gmail.com
Responsible Changed From-To: freebsd-ports-bugs->swills I'll take it.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The attached patch fixes it so that it builds on both 9.x and 8.x. Patch is also available here: http://people.freebsd.org/~swills/fusefs_kmod_patch.txt in case it gets lost. Without the conditionalization, it breaks on 8.x. There wasn't a OSVERSION bump for the change to vfs_flagopt, so I used the closest thing I could find. Maintainer, do you approve? Thanks, Steve -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJOdpCKAAoJEPXPYrMgexuhj28H/AoXnCpygkErYRyjaos4hJH/ 1tHB2XGqcCPdXLtX66tWInUAB6PHtczeOKNS5WKjFO2wbdHi8hdy+MShQ5LKnLcy 5zDRAnu4VfY64Ng7R74LnBCV/FKSDcb4xaVFJRVhRV2hlTsYN3S6drwb6fGDkFM/ eOZuq/u+Fx+LB25NK9Xpr0e2FjRqq+xdqyu+DrhgQ6bl2iiBsXsMzilXJUTYVOR0 fUJjyMHftzF3zxw2X6Zu8yo/DrTtPkYJD1MwWDeWabezo9gJzXUwRkJCCyZ7EmG8 3K/F9tXPg1QtDZP3THepKNQBg9TRjlBI7MlvZyFEgkk9HjWj4pFR7FTCsLk6eso= =edTI -----END PGP SIGNATURE-----
Hello! This problem too is present in i386 to architecture. Please correct it there too.
On Wed, Sep 21, 2011 at 10:19 AM, =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0= =BD=D0=B4=D1=80 =D0=95=D1=84=D1=80=D0=B5=D0=BC=D0=BE=D0=B2 <mr.efrem@gmail.= com> wrote: > Hello! > > This problem too is present in i386 to architecture. Please correct it th= ere > too. I see that the port was re-assigned to heap last night. Can someone please commit either Steve's or my fix? I really prefer mine as it only re-types the two variables that need it, although my read of the code leads me to believe that re-typing of the remaining variables will make no difference as they are only used internally and never passed as arguments. It is possible that making them unsigned might cause a problem, but it looks unlikely to me. Still, I tend to always lean to the more conservative side unless I am really sure I fully understand hte code. --=20 R. Kevin Oberman, Network Engineer - Retired E-mail: kob6558@gmail.com
swills 2011-09-21 20:29:34 UTC FreeBSD ports repository Modified files: sysutils/fusefs-kmod Makefile Added files: sysutils/fusefs-kmod/files extra-patch-fuse_module__fuse_vnops.c Log: - Fix build on 9-CURRENT PR: ports/160608 (plus many other) Submitted by: Kevin Oberman <kob6558@gmail.com> (based on) Revision Changes Path 1.33 +5 -1 ports/sysutils/fusefs-kmod/Makefile 1.1 +11 -0 ports/sysutils/fusefs-kmod/files/extra-patch-fuse_module__fuse_vnops.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Thanks for the info and feedback. Fix committed.