Bug 160608 - sysutils/fusefs-kmod fails to build on amd64
Summary: sysutils/fusefs-kmod fails to build on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-10 04:50 UTC by Kevin Oberman
Modified: 2011-09-21 21:30 UTC (History)
0 users

See Also:


Attachments
file.diff (426 bytes, patch)
2011-09-10 04:50 UTC, Kevin Oberman
no flags Details | Diff
fusefs_kmod_patch.txt (1.57 KB, text/plain)
2011-09-19 01:44 UTC, Steve Wills
no flags Details
fusefs_kmod_patch.txt.sig (287 bytes, application/octet-stream)
2011-09-19 01:44 UTC, Steve Wills
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Oberman 2011-09-10 04:50:08 UTC
Building of the fusefs-kmod port failed in fuse_modules/fuse_vfsops.c due to an incorrect typing of the third argument of calls to vfs_flagopt. It the variables 'mntopts and __mntopts are declared to be int when vfs_flagopt expects uint64_t.

fuse_vfsops.c: In function 'fuse_mount':
fuse_vfsops.c:339: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:339: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:340: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:340: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:341: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:341: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:342: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:342: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:343: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type
fuse_vfsops.c:343: warning: passing argument 3 of 'vfs_flagopt' from incompatible pointer type

Proposed fix may not be correct, but it did allow the port to build. Perhaps a cast would have been the right answer.

How-To-Repeat: cd /usr/ports/sysutils/fusefs-kmod && make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-10 04:50:17 UTC
Maintainer of sysutils/fusefs-kmod,

Please note that PR ports/160608 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160608

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-10 04:50:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Ivan Klymenko 2011-09-10 07:34:42 UTC
This problem report is a duplicate
http://www.freebsd.org/cgi/query-pr.cgi?pr=159361&cat=
Comment 4 Kevin Oberman 2011-09-10 17:21:51 UTC
On Fri, Sep 9, 2011 at 11:34 PM, Ivan Klymenko <fidaj@ukr.net> wrote:
> This problem report is a duplicate
> http://www.freebsd.org/cgi/query-pr.cgi?pr=159361&cat=

PR ports/159361 is a bit of a mess as it conflates two PRa related to
the fusefs-kmod port.

The long patch in the PR is mostly changes that are already committed
to the port. Only a single
change, from 'int' to 'uint64_t' in the third hunk is required, as far
as I can tell. It changes three
variables from 'int' to 'uint64_t', where mine only changed the first
two, but I can't say which is
more correct and it may make no difference.

Please don't assume that the committed patch is the complete fix.
-- 
R. Kevin Oberman, Network Engineer - Retired
E-mail: kob6558@gmail.com
Comment 5 Steve Wills freebsd_committer freebsd_triage 2011-09-19 01:33:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

I'll take it.
Comment 6 Steve Wills freebsd_committer freebsd_triage 2011-09-19 01:44:59 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The attached patch fixes it so that it builds on both 9.x and 8.x. Patch
is also available here:

http://people.freebsd.org/~swills/fusefs_kmod_patch.txt

in case it gets lost.

Without the conditionalization, it breaks on 8.x. There wasn't a
OSVERSION bump for the change to vfs_flagopt, so I used the closest
thing I could find.

Maintainer, do you approve?

Thanks,
Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQEcBAEBAgAGBQJOdpCKAAoJEPXPYrMgexuhj28H/AoXnCpygkErYRyjaos4hJH/
1tHB2XGqcCPdXLtX66tWInUAB6PHtczeOKNS5WKjFO2wbdHi8hdy+MShQ5LKnLcy
5zDRAnu4VfY64Ng7R74LnBCV/FKSDcb4xaVFJRVhRV2hlTsYN3S6drwb6fGDkFM/
eOZuq/u+Fx+LB25NK9Xpr0e2FjRqq+xdqyu+DrhgQ6bl2iiBsXsMzilXJUTYVOR0
fUJjyMHftzF3zxw2X6Zu8yo/DrTtPkYJD1MwWDeWabezo9gJzXUwRkJCCyZ7EmG8
3K/F9tXPg1QtDZP3THepKNQBg9TRjlBI7MlvZyFEgkk9HjWj4pFR7FTCsLk6eso=
=edTI
-----END PGP SIGNATURE-----
Comment 7 mr.efrem 2011-09-21 18:19:07 UTC
Hello!

This problem too is present in i386 to architecture. Please correct it there
too.
Comment 8 Kevin Oberman 2011-09-21 18:57:02 UTC
On Wed, Sep 21, 2011 at 10:19 AM, =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=
=BD=D0=B4=D1=80 =D0=95=D1=84=D1=80=D0=B5=D0=BC=D0=BE=D0=B2 <mr.efrem@gmail.=
com> wrote:
> Hello!
>
> This problem too is present in i386 to architecture. Please correct it th=
ere
> too.

I see that the port was re-assigned to heap last night. Can someone
please commit either
Steve's or my fix?

I really prefer mine as it only re-types the two variables that need it,
although my read of the code leads me to believe that re-typing of the
remaining variables
will make no difference as they are only used internally and never
passed as arguments.
It is possible that making them unsigned might cause a problem, but it
looks unlikely to me.

Still, I tend to always lean to the more conservative side unless I am
really sure I fully understand hte code.
--=20
R. Kevin Oberman, Network Engineer - Retired
E-mail: kob6558@gmail.com
Comment 9 dfilter service freebsd_committer freebsd_triage 2011-09-21 21:29:43 UTC
swills      2011-09-21 20:29:34 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/fusefs-kmod Makefile 
  Added files:
    sysutils/fusefs-kmod/files 
                               extra-patch-fuse_module__fuse_vnops.c 
  Log:
  - Fix build on 9-CURRENT
  
  PR:             ports/160608 (plus many other)
  Submitted by:   Kevin Oberman <kob6558@gmail.com> (based on)
  
  Revision  Changes    Path
  1.33      +5 -1      ports/sysutils/fusefs-kmod/Makefile
  1.1       +11 -0     ports/sysutils/fusefs-kmod/files/extra-patch-fuse_module__fuse_vnops.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Steve Wills freebsd_committer freebsd_triage 2011-09-21 21:30:28 UTC
State Changed
From-To: feedback->closed

Thanks for the info and feedback. Fix committed.