Bug 160859 - [PATCH] www/py-tornado: depend on simplejson conditionally
Summary: [PATCH] www/py-tornado: depend on simplejson conditionally
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 22:10 UTC by R.Mahmatkhanov
Modified: 2011-09-23 21:10 UTC (History)
0 users

See Also:

Attachments
file.diff (1.51 KB, patch)
2011-09-20 22:10 UTC, R.Mahmatkhanov 		no flags Details | Diff
py-tornado.patch (2.78 KB, patch)
2011-09-22 08:21 UTC, khsing.cn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-09-20 22:10:05 UTC 
This port is only needed simplejson if it run with python less than 2.6. From README:

"""
To use all of the features of Tornado, you need to have PycURL 
and (for Python 2.5 only) simplejson installed.

"""

so patch attached makes it depend on simplejson only if python version is < 2.6.
- bump portrevision because of dependency change

tag: simplejson26

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-20 22:10:22 UTC 
Maintainer of www/py-tornado,

Please note that PR ports/160859 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160859

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-20 22:10:24 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 khsing.cn 2011-09-22 08:21:08 UTC 
Approved
I have modified this patch and update this ports.

On Wed, Sep 21, 2011 at 5:10 AM, Edwin Groothuis <edwin@freebsd.org> wrote:
> Maintainer of www/py-tornado,
>
> Please note that PR ports/160859 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160859
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>




-- 
A man live in jail and want to break.
http://blog.khsing.net
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-09-22 08:55:19 UTC 
State Changed
From-To: feedback->open

Maintainer approved, with modified patch.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-09-22 08:56:56 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-09-23 21:04:54 UTC 
sunpoet     2011-09-23 20:04:45 UTC

  FreeBSD ports repository

  Modified files:
    www/py-tornado       Makefile pkg-descr 
  Log:
  - Set py-simplejson as conditional dependency
  - Bump PORTREVISION for dependency change
  - Update pkg-descr
  
  PR:             ports/160859
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  Approved by:    khsing <khsing.cn@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.6       +9 -3      ports/www/py-tornado/Makefile
  1.2       +13 -8     ports/www/py-tornado/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-09-23 21:05:03 UTC 
State Changed
From-To: open->closed

Committed. Thanks!