Bug 161220 - [patch] editors/emacs-devel: debug-on-quit doesn't interrupt loops
Summary: [patch] editors/emacs-devel: debug-on-quit doesn't interrupt loops
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-02 05:40 UTC by Nali Toja
Modified: 2011-10-17 12:22 UTC (History)
0 users

See Also:

Attachments
use_sigio.diff (299 bytes, patch)
2011-10-02 05:40 UTC, Nali Toja 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nali Toja 2011-10-02 05:40:08 UTC 

Fix: copied from src/s/darwin.h and src/s/gnu-kfreebsd.h
How-To-Repeat: 1. launch as `emacs -Q'
2. M-x toggle-debug-on-quit
3. eval a basic loop, e.g. `(while t)'
4. hit C-g aka `keyboard-quit'

it should hang and never show a backtrace
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-02 05:40:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Nali Toja 2011-10-02 06:20:12 UTC 
I can't reproduce it on X11 build, e.g. with GTK2 toolkit.
So, it should be tested in `-nw' mode, e.g `emacs -Q -nw'.

Also, BROKEN_SIGIO probably doesn't affect us unlike, say, OpenBSD.
It's not defined for GNU/kFreeBSD and Darwin and seems to work fine with
X11 based on my limited testing.
Comment 3 Nali Toja 2011-10-02 12:45:08 UTC 
Hmm, found it upstream. The included patch also makes `debug-on-quit' work.

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6649
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-10-17 05:55:41 UTC 
ashish      2011-10-17 04:55:31 UTC

  FreeBSD ports repository

  Modified files:
    editors/emacs-devel  Makefile distinfo 
    editors/emacs-devel/files patch-configure.in 
  Added files:
    editors/emacs-devel/files patch-src_process.c 
                              patch-src_s_freebsd.h 
  Log:
  - Update to bzr revision 106087
  - Fix detection of 'make' program in use in configure script[1]
  - Use openpty(3) instead of deprecated pty(4) interface[2]
  - Add patch to interrupt `debug-on-quit' during loops[3]
  - Track ncurses dependency[4]
  
  PR:             ports/160986[1], ports/161181[2], ports/161220[3], ports/161497[4]
  Submitted by:   h h <aakusta@gmail.com>[1], Nali Toja <nalitoja@gmail.com>[2][3][4]
  
  Revision  Changes    Path
  1.58      +2 -2      ports/editors/emacs-devel/Makefile
  1.31      +2 -2      ports/editors/emacs-devel/distinfo
  1.9       +20 -2     ports/editors/emacs-devel/files/patch-configure.in
  1.1       +16 -0     ports/editors/emacs-devel/files/patch-src_process.c (new)
  1.1       +25 -0     ports/editors/emacs-devel/files/patch-src_s_freebsd.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2011-10-17 12:22:35 UTC 
State Changed
From-To: open->closed

Committed. Thanks!