- Update to 1.01 Fix dependencys of perl modules Port maintainer (stephon@pixnet.tw) is cc'd. Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->perl perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Maintainer of mail/p5-SES, Please note that PR ports/161295 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161295 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hello Ports Committer, I approve this patch Sincerely Yours -- stephon On Wed, Oct 5, 2011 at 2:00 PM, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of mail/p5-SES, > > Please note that PR ports/161295 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161295 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org >
Responsible Changed From-To: perl->culot I'll take it.
Hi Stephon, thanks for submitting this update, however there are some points I would like to mention: 1. there is a typo in the dependencies declaration preventing the package from installing properly: s/p5-XMK-LibXML/p5-XML-LibXML/ 2. the backslash at the last line of the RUN_DEPENDS section should not be there. 3. the code is published under the Apache license, hence I believe the following line should be added to the Makefile: LICENSE= ASL But my main concern is with regards to the archive itself: you update PORTVERSION but the archive that is downloaded remains the same (no change in DISTNAME). Moreover the version of this archive is dated 2011-03-03 but according to the Changelog found at: http://aws.amazon.com/code/Amazon-SES/8945574369528337 the latest version is dated 2011-10-31. Hence I wanted to make sure that we were using the proper archive here. If yes, wouldn't it be more appropriate to only bump PORTREVISION instead of increasing PORTVERSION as only dependencies are changed? Could you please clarify the abovementioned points? Thanks, culot@
Hello Culot On Wed, Nov 16, 2011 at 21:49, Frederic Culot <culot@freebsd.org> wrote: > Hi Stephon, > > thanks for submitting this update, however there are some points I would > like to > mention: > > 1. there is a typo in the dependencies declaration preventing the package > from > installing properly: > > s/p5-XMK-LibXML/p5-XML-LibXML/ > Here is a typo, it should be p5-XML-LibXML > > 2. the backslash at the last line of the RUN_DEPENDS section should not be > there. > Got > > 3. the code is published under the Apache license, hence I believe the > following > line should be added to the Makefile: > > LICENSE= ASL Got it > > > But my main concern is with regards to the archive itself: you update > PORTVERSION but the archive that is downloaded remains the same (no change > in > DISTNAME). Moreover the version of this archive is dated 2011-03-03 but > according to the Changelog found at: > > http://aws.amazon.com/code/Amazon-SES/8945574369528337 > > the latest version is dated 2011-10-31. Hence I wanted to make sure that > we were > using the proper archive here. If yes, wouldn't it be more appropriate to > only > bump PORTREVISION instead of increasing PORTVERSION as only dependencies > are > changed? > > Because of my submit is on Oct 5, hence there was no new version of Amazon SES at that time Thus I have not checked whether the new version had updated in 2011-10-31. You could close this ticket as invalid, and I'll send a new PR to resolve it. Could you please clarify the abovementioned points? > Thanks, > culot@ > Thanks a lot -- stephon
State Changed From-To: feedback->closed Closed on submitter's request.
culot 2011-11-30 08:38:02 UTC FreeBSD ports repository Modified files: mail/p5-SES Makefile distinfo Log: - Update to 1.01 - Add LICENSE (Apache) - Update maintainer's address (submitted via private email) Changes: http://aws.amazon.com/code/Amazon-SES/8945574369528337 PR: ports/161295 Submitted by: Stephon Chen <stephon@gmail.com> (maintainer) Feature safe: yes Revision Changes Path 1.2 +12 -6 ports/mail/p5-SES/Makefile 1.3 +2 -2 ports/mail/p5-SES/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"