This version requires the use of ppd, but cups/ppd.h is not included. I did not tested gcc42, but for gcc46 & and clang, this version does not build.
Responsible Changed From-To: freebsd-ports-bugs->chromium Over to maintainer (via the GNATS Auto Assign Tool)
patch not work uname -a FreeBSD 8.2-STABLE #0: Wed Sep 21 17:24:21 EEST 2011 =20 root@xxx.xxx.xxx:/usr/obj/usr/src/sys/Kernel amd64 =2E..[cut]... CXX(target)=20 out/Release/obj.target/browser/chrome/browser/ui/webui/plugins_ui.o CXX(target)=20 out/Release/obj.target/browser/chrome/browser/ui/webui/print_preview_data= _source.o CXX(target)=20 out/Release/obj.target/browser/chrome/browser/ui/webui/print_preview_hand= ler.o chrome/browser/ui/webui/print_preview_handler.cc: In member function=20 'void PrintSystemTaskProxy::GetPrinterCapabilities(const std::string&)': chrome/browser/ui/webui/print_preview_handler.cc:291: error:=20 'ppd_file_t' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:291: error: 'ppd' was=20 not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:291: error:=20 'ppdOpenFile' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:293: error:=20 'ppd_attr_t' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:293: error: 'attr' was=20 not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:293: error:=20 'ppdFindAttr' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:297: error:=20 'ppd_choice_t' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:297: error: 'ch' was=20 not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:297: error:=20 'ppdFindMarkedChoice' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:299: error:=20 'ppd_option_t' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:299: error: 'option'=20 was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:299: error:=20 'ppdFindOption' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:301: error:=20 'ppdFindChoice' was not declared in this scope chrome/browser/ui/webui/print_preview_handler.cc:307: error: 'ppdClose'=20 was not declared in this scope gmake: ***=20 [out/Release/obj.target/browser/chrome/browser/ui/webui/print_preview_han= dler.o]=20 =EF=DB=C9=C2=CB=C1 1 gmake: *** =EF=D6=C9=C4=C1=CE=C9=C5 =DA=C1=D7=C5=D2=DB=C5=CE=C9=D1 =DA=C1= =C4=C1=CE=C9=CA... *** Error code 1 Stop in /usr/ports/www/chromium. *** Error code 1 Stop in /usr/ports/www/chromium. =3D=3D=3D>>> make failed for www/chromium =3D=3D=3D>>> Aborting update =3D=3D=3D>>> You can restart from the point of failure with this command = line: portmaster <flags> www/chromium -- Best regards Alexander Panyushkin
the patch fix the build for me, tested on FreeBSD 8 & 9 amd64, with option gcc45 and clang
Add the following patch to "files" folder: #cat patch-chrome__browser__ui__webui__print_preview_handler.cc --- chrome/browser/ui/webui/print_preview_handler.cc.orig 2011-10-06 09:38:17.000000000 +0000 +++ chrome/browser/ui/webui/print_preview_handler.cc 2011-10-06 09:38:17.000000000 +0000 @@ -46,6 +46,7 @@ #if defined(USE_CUPS) #include <cups/cups.h> +#include <cups/ppd.h> #include "base/file_util.h" #endif ------------------------------------------------- This message sent via VFEmail.net http://www.vfemail.net $14.95 Lifetime accounts! 15GB disk! Commercial Mail Options! No bandwidth quotas!
rene 2011-10-06 22:32:37 UTC FreeBSD ports repository Added files: www/chromium/files patch-chrome__browser__ui__webui__print_preview_handler.cc Log: Fix build with GCC 4.6, no PORTREVISION bump. PR: ports/161323 Submitted by: Zhihao Yuan [lichray gmail] Revision Changes Path 1.1 +10 -0 ports/www/chromium/files/patch-chrome__browser__ui__webui__print_preview_handler.cc (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed (without PORTREVISION bump), thanks