Bug 161463 - [patch] Mk/bsd.gecko.mk: remove some vendor optimization for WITHOUT_OPTIMIZED_CFLAGS
Summary: [patch] Mk/bsd.gecko.mk: remove some vendor optimization for WITHOUT_OPTIMIZE...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beat Gaetzi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 16:40 UTC by Nali Toja
Modified: 2011-10-23 19:40 UTC (History)
0 users

See Also:

Attachments
optimize.diff (933 bytes, patch)
2011-10-10 16:40 UTC, Nali Toja 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nali Toja 2011-10-10 16:40:03 UTC 
Since bug#680277 optimized builds always add -fomit-frame-pointer after
user CFLAGS which makes it harder to capture callchain information using
pmcstat(8), dtrace(1) or gdb(1). And since --enable-optimize is enabled
by default there is no way around short of defining WITH_DEBUG that may
have undesirable effects, e.g.

  CFLAGS := ${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS} # from bsd.port.mk
  MOZ_DEBUG_ENABLE_DEFS="-DDEBUG -D_DEBUG -DTRACING" # from configure.in

How-To-Repeat: $ cd www/firefox; make install STRIP=
$ firefox &
$ pmcstat -t firefox -P instructions -T

and look at the CALLERS column for libxul.so
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-10 16:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gecko

bsd.gecko.mk is gecko territory (via the GNATS Auto Assign Tool)
Comment 2 Beat Gaetzi freebsd_committer freebsd_triage 2011-10-19 19:58:31 UTC 
Responsible Changed
From-To: gecko->beat

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-10-23 19:32:12 UTC 
beat        2011-10-23 18:31:57 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.gecko.mk 
  Log:
  - Remove some vendor optimization for WITHOUT_OPTIMIZED_CFLAGS
  
  PR:             ports/161463
  Submitted by:   Nali Toja <nalitoja AT gmail.com>
  
  Revision  Changes    Path
  1.44      +4 -4      ports/Mk/bsd.gecko.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Beat Gaetzi freebsd_committer freebsd_triage 2011-10-23 19:40:44 UTC 
State Changed
From-To: open->closed

Committed. Thanks!