Bug 161567 - [PATCH] audio/pulseaudio: fix pkg-plist
Summary: [PATCH] audio/pulseaudio: fix pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 03:10 UTC by takefu
Modified: 2011-11-03 12:52 UTC (History)
1 user (show)

See Also:


Attachments
pulseaudio.patch (714 bytes, patch)
2011-10-14 03:10 UTC, takefu
no flags Details | Diff
p (585 bytes, text/plain)
2011-10-14 15:36 UTC, John Hein
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2011-10-14 03:10:04 UTC

    
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-14 03:10:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 John Hein 2011-10-14 15:36:57 UTC
gnats wrote:
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=161567

To save someone the trouble of hunting this down, the evdev module
gets built/installed if multimedia/v4l_compat is installed.
pulseaudio's looks for linux/input.h to decide whether to build the
evdev module.

As such, the existence of linux/input.h is not really a good
indication of a working evdev.

In any case, the patch to hard-code evdev in pkg-plist is not
appropriate at this time since installations that don't have
multimedia/v4l_compat will have a broken plist as well (the evdev
module won't be installed but the plist will say it is).

An alternate workaround would be to add the attached hunk to
files/patch-configure to forcibly tell it there is no evdev on
freebsd...
Comment 3 takefu 2011-11-03 08:28:20 UTC
ãããµï¼ å¤§éªè±ä¸­ã§ãã

It is good.
I think that the patch that I sent is discontinued, and the patch that you wrote is good.

John Hein ããã¯æ¸ãã¾ãã (2011/10/14 23:36):
> gnats wrote:
>  > http://www.freebsd.org/cgi/query-pr.cgi?pr=161567
> 
> To save someone the trouble of hunting this down, the evdev module
> gets built/installed if multimedia/v4l_compat is installed.
> pulseaudio's looks for linux/input.h to decide whether to build the
> evdev module.
> 
> As such, the existence of linux/input.h is not really a good
> indication of a working evdev.
> 
> In any case, the patch to hard-code evdev in pkg-plist is not
> appropriate at this time since installations that don't have
> multimedia/v4l_compat will have a broken plist as well (the evdev
> module won't be installed but the plist will say it is).
> 
> An alternate workaround would be to add the attached hunk to
> files/patch-configure to forcibly tell it there is no evdev on
> freebsd...
> 


--
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-11-03 12:25:39 UTC
kwm         2011-11-03 12:25:26 UTC

  FreeBSD ports repository

  Modified files:
    audio/pulseaudio     Makefile 
  Added files:
    audio/pulseaudio/files extra-src_modules_oss_module-oss.c 
  Removed files:
    audio/pulseaudio/files extra-patch-src_daemon_main.c 
                           extra-patch-src_daemon_start-pulseaudio-x11.in 
                           extra-patch-src_pulse_context.c 
  Log:
  Update MASTER_SITE
  Don't pickup linux/input.h, this should fix plist failure because the evdev
  modules is build (which is useless for us). [2]
  Disable alsa support..
  Remove FreeBSD 6.x patch.
  Disable mmap support on FreeBSD versions that don't have support for it. [1]
  
  PR:             ports/161567 [2]
  Submitted by:   avg@ [1]
  Reported by:    Takefu <takefu@airport.fm> [2]
  
  Revision  Changes    Path
  1.67      +13 -20    ports/audio/pulseaudio/Makefile
  1.2       +0 -20     ports/audio/pulseaudio/files/extra-patch-src_daemon_main.c (dead)
  1.2       +0 -11     ports/audio/pulseaudio/files/extra-patch-src_daemon_start-pulseaudio-x11.in (dead)
  1.2       +0 -11     ports/audio/pulseaudio/files/extra-patch-src_pulse_context.c (dead)
  1.1       +11 -0     ports/audio/pulseaudio/files/extra-src_modules_oss_module-oss.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Koop Mast freebsd_committer freebsd_triage 2011-11-03 12:51:55 UTC
State Changed
From-To: open->closed

Committed a solution for this issue, thanks for reporting!