Bug 161856 - [patch] emulators/qemu-devel: respect STRIP
Summary: [patch] emulators/qemu-devel: respect STRIP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Juergen Lock
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-21 06:40 UTC by Nali Toja
Modified: 2011-10-22 20:00 UTC (History)
0 users

See Also:

Attachments
strip.diff (608 bytes, patch)
2011-10-21 06:40 UTC, Nali Toja 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nali Toja 2011-10-21 06:40:10 UTC 
Do not strip uncoditionally, it makes system-wide profiling more cumbersome.

How-To-Repeat: $ make install STRIP=
$ qemu &

# qemu itself + libs/kernel
$ pmcstat -t qemu -P instructions -T

# system-wide with lots of noise from other apps
$ pmcstat -S instructions -T
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-21 06:41:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->nox

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Nali Toja 2011-10-21 07:12:18 UTC 
Nali Toja <nalitoja@gmail.com> writes:

>>Description:
> Do not strip uncoditionally, it makes system-wide profiling more cumbersome.

Also, STRIP is used by WITH_DEBUG in bsd.port.mk.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-10-22 19:56:14 UTC 
nox         2011-10-22 18:56:05 UTC

  FreeBSD ports repository

  Modified files:
    emulators/qemu-devel Makefile pkg-plist 
  Log:
  - Respect CC (sgabios) [1]
  - Respect STRIP [2]
  - Respect NOPORTDOCS, even if it's empty [3]
  - Trim deps for -nographic [4]
  
  PR:             ports/161855 [1], ports/161856 [2], ports/161857 [3],
                  ports/161858 [4]
  Submitted by:   Nali Toja <nalitoja@gmail.com>
  
  Revision  Changes    Path
  1.129     +32 -8     ports/emulators/qemu-devel/Makefile
  1.32      +1 -1      ports/emulators/qemu-devel/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-10-22 19:57:39 UTC 
nox         2011-10-22 18:57:32 UTC

  FreeBSD ports repository

  Modified files:
    emulators/qemu       Makefile 
  Log:
  - Respect STRIP [1]
  - Respect NOPORTDOCS, even if it's empty [2]
  
  PR:             ports/161856 [1], ports/161857 [2]
  Submitted by:   Nali Toja <nalitoja@gmail.com>
  
  Revision  Changes    Path
  1.121     +5 -1      ports/emulators/qemu/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Juergen Lock freebsd_committer freebsd_triage 2011-10-22 19:59:06 UTC 
State Changed
From-To: open->closed

Committed. Thanks!