Bug 161951 - mail/dovecot2-antispam-plugin hangs fails when built without $HOME set and no ksh
Summary: mail/dovecot2-antispam-plugin hangs fails when built without $HOME set and no...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-24 03:30 UTC by Jan Martin Mikkelsen
Modified: 2011-12-03 18:40 UTC (History)
0 users

See Also:


Attachments
file.diff (275 bytes, patch)
2011-10-24 03:30 UTC, Jan Martin Mikkelsen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Martin Mikkelsen 2011-10-24 03:30:01 UTC
Building the mail/dovecot2-antispam-plugin port fails when ksh is not installed and $HOME is not set. Installing shells/pdksh makes the build hang rather than complete, so adding that as a build dependency does not help.

The cause is the txt2man script in the port that attempts to figure out whether it has a modern /bin/sh and feeds itself to ksh if it doesn't. FreeBSD has a modern /bin/sh and doesn't always have ksh, so the test can cause problems.

See attached patch for resolution.

Fix: Put the following into mail/dovecot2-antispam-plugin/files/patch-txt2man 
How-To-Repeat: Attempt to build the port after clearing the environment. "sudo env - make package" in the port directory should be sufficient.

Build command that demonstrated  the problem was:

/usr/sbin/chroot /home/janm/p4/freebsd-image-std-2008.2/work/build-chroot \
 /usr/bin/env - \
 PATH=/sbin:/bin:/usr/bin:/usr/sbin:/usr/local/sbin:/usr/local/bin:/usr/X11R6/bin \
 /bin/sh -cxe '
 cd /usr/ports/mail/dovecot2-antispam-plugin
 env NO_MTREE="true" make package WRKDIRPREFIX=/ports-work PKGFILE='/ports-packages/dovecot2-antispam-plugin-20101222.tbz' BATCH=yes NODEPENDS=yes PACKAGE_BUILDING=yes'
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-24 03:30:09 UTC
Maintainer of mail/dovecot2-antispam-plugin,

Please note that PR ports/161951 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161951

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-24 03:30:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2011-12-02 02:05:27 UTC
State Changed
From-To: feedback->open

I'll take it 


Comment 4 Michael Scheidell freebsd_committer freebsd_triage 2011-12-02 02:05:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2011-12-03 18:24:29 UTC
State Changed
From-To: open->closed

Added patch-for docs/txtman
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-12-03 18:31:25 UTC
scheidell    2011-12-03 18:31:16 UTC

  FreeBSD ports repository

  Modified files:
    mail/dovecot2-antispam-plugin Makefile 
  Added files:
    mail/dovecot2-antispam-plugin/files patch-docs-txt2man 
  Log:
  - Patched txt2man because of an overly,unnessessary agressive test
  - without patch build would hang
  
  PR:             161951
  Submitted by:   janm@transactionware.com
  Approved by:    maintainer (timeout), gabor (mentor)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.2       +3 -2      ports/mail/dovecot2-antispam-plugin/Makefile
  1.1       +10 -0     ports/mail/dovecot2-antispam-plugin/files/patch-docs-txt2man (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"