Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
State Changed From-To: open->feedback There's something wrong with disfile, please see: http://people.freebsd.org/~pawel/buildlogs/7/samesame-1.10.log
Responsible Changed From-To: pawel->freebsd-ports-bugs No submitter response, back to the pool
The e-mail adress I specified is wrong. The correct distinfo is: MD5 (samesame-1.10.tar.bz2) = f6dec0724a88d1667c80fa44beefca6e SHA256 (samesame-1.10.tar.bz2) = 9793649925d70a2b9a44aeed4e8f475cfb544296371ddd7c37f8000d14e44d0a SIZE (samesame-1.10.tar.bz2) = 121316
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
The rc script needs to be rewritten to conform with new format: Please review http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html and submit a new rc script. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
Responsible Changed From-To: scheidell->freebsd-ports-bugs Back to pool.
State Changed From-To: feedback->open Feedback Timeout.
The RC script is installed conditionally, depending on the options the user chose. It cleans up directories in /tmp/ so it must run before cleantmp or it will result in an error on the screen. If it is run after login, then this might cause unexpected behavior, so its run before login. --- samesame.diff2 begins here --- diff -ru -ru port.org/Makefile port/Makefile --- port.org/Makefile Sun Mar 18 23:08:56 2012 +++ port/Makefile Sun Mar 18 23:51:20 2012 @@ -25,6 +25,9 @@ bin/samearchive-lite bin/sameln bin/samemv \ bin/samechflags bin/samerm bin/samechmod \ bin/samechown bin/samedelay +.if defined(WITH_DISK_STORAGE) +USE_RC_SUBR= samesame_clean +.endif HAS_CONFIGURE= yes CONFIGURE_ARGS= --enable-samechflags --enable-samechmod \ @@ -47,7 +50,6 @@ .if defined(WITH_DISK_STORAGE) CONFIGURE_ARGS+= --enable-disk-storage -PLIST_FILES+= etc/rc.d/samesame.sh .endif .if defined(WITH_EXPERIMENTAL) @@ -87,9 +89,6 @@ .if defined(WITH_EXPERIMENTAL) ${STRIP_CMD} ${PREFIX}/bin/fsort .endif -.endif -.if defined(WITH_DISK_STORAGE) - ${INSTALL_SCRIPT} ${FILESDIR}/samesame.sh ${PREFIX}/etc/rc.d/ .endif @${ECHO} @${CAT} pkg-message Only in port.org/files: samesame.sh Only in port/files: samesame_clean.in --- samesame.diff2 ends here --- --- samesame_clean.in begins here --- # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # port/files/samesame_clean.in # echo x - port/files/samesame_clean.in sed 's/^X//' >port/files/samesame_clean.in << 'END-of-port/files/samesame_clean.in' X#!/bin/sh X# X# $FreeBSD$ X# X X# PROVIDE: samesame_clean X# REQUIRE: DAEMON X# BEFORE: LOGIN cleantmp X# KEYWORD: shutdown X# X Xname=samesame_clean Xstart_cmd="${name}_start" X Xsamesame_clean_start() { X rm -rf /tmp/samefile /tmp/samearchive X ;; X} X Xload_rc_config $name Xrun_rc_command "$1" X END-of-port/files/samesame_clean.in exit --- samesame_clean.in ends here ---
Could you try re-submitting your patch? it seems to not have been taken by GNATS as an attachment. it needs to be a valid MIME attachment if you submitted this by email. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
>Submitter-Id: current-users >Originator: Alex de Kruijff >Organization: >Confidential: no >Synopsis: Re: ports/161981: [maintainer update] sysutils/samesame to v1.10 >Severity: non-critical >Priority: low >Category: ports >Class: maintainer-update >Release: FreeBSD 6.1-RELEASE-p20 i386 >Environment: System: FreeBSD Zeus 6.1-RELEASE-p20 FreeBSD 6.1-RELEASE-p20 #0: Wed Nov 14 02:07:49 CET 2007 akruijff@Server1.lan:/temp/obj/temp/src/sys/SERVER-SMP i386 >Description: >How-To-Repeat: >Fix: --- samesame.diff2 begins here --- diff -ru -ru port.org/Makefile port/Makefile --- port.org/Makefile Sun Mar 18 23:08:56 2012 +++ port/Makefile Sun Mar 18 23:51:20 2012 @@ -25,6 +25,9 @@ bin/samearchive-lite bin/sameln bin/samemv \ bin/samechflags bin/samerm bin/samechmod \ bin/samechown bin/samedelay +.if defined(WITH_DISK_STORAGE) +USE_RC_SUBR= samesame_clean +.endif HAS_CONFIGURE= yes CONFIGURE_ARGS= --enable-samechflags --enable-samechmod \ @@ -47,7 +50,6 @@ .if defined(WITH_DISK_STORAGE) CONFIGURE_ARGS+= --enable-disk-storage -PLIST_FILES+= etc/rc.d/samesame.sh .endif .if defined(WITH_EXPERIMENTAL) @@ -87,9 +89,6 @@ .if defined(WITH_EXPERIMENTAL) ${STRIP_CMD} ${PREFIX}/bin/fsort .endif -.endif -.if defined(WITH_DISK_STORAGE) - ${INSTALL_SCRIPT} ${FILESDIR}/samesame.sh ${PREFIX}/etc/rc.d/ .endif @${ECHO} @${CAT} pkg-message diff -ru -ru port.org/distinfo port/distinfo --- port.org/distinfo Sun Mar 18 23:08:56 2012 +++ port/distinfo Sun Mar 18 23:53:13 2012 @@ -1,3 +1,4 @@ MD5 (samesame-1.10.tar.bz2) = f6dec0724a88d1667c80fa44beefca6e -SHA256 (samesame-1.10.tar.bz2) = 9793649925d70a2b9a44aeed4e8f475cfb544296371ddd7c37f8000d14e44d0a +SHA256 (samesame-1.10.tar.bz2) = +9793649925d70a2b9a44aeed4e8f475cfb544296371ddd7c37f8000d14e44d0a SIZE (samesame-1.10.tar.bz2) = 121316 Only in port.org/files: samesame.sh Only in port/files: samesame_clean.in Only in port: work --- samesame.diff2 ends here --- --- samesame_clean.in begins here --- #!/bin/sh # # $FreeBSD$ # # PROVIDE: samesame_clean # REQUIRE: DAEMON # BEFORE: LOGIN cleanvar # KEYWORD: shutdown # name=samesame_clean start_cmd="${name}_start" samesame_clean_start() { rm -rf /tmp/samefile /tmp/samearchive ;; } load_rc_config $name run_rc_command "$1" --- samesame_clean.in ends here ---
Please revisit pr AFTER you try to attach a mime compliant attachment. if you can't click on a link and fully download the patch, then you didn't do it right, or your mail client clobbered it, or the dog ate your homework. (see first 'Fix' and see how the patch stands out?) -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
State Changed From-To: open->closed Committed, with minor changes. Thanks!