Attached is a patch, seeking re-integration which enables the option of building the python bindings on net-mgmt/net-snmp. --- Makefile 2011-10-31 14:24:16.211903689 +1100 +++ Makefile.orig 2011-09-07 11:49:27.000000000 +1000 @@ -23,8 +23,7 @@ DUMMY "Enable dummy values as placeholders" on \ TKMIB "Install graphical MIB browser" off \ DMALLOC "Enable dmalloc debug memory allocator" off \ - UNPRIVILEGED "Allow unprivileged users to execute net-snmp" off \ - PYTHON "Install python bindings" on + UNPRIVILEGED "Allow unprivileged users to execute net-snmp" off MAKE_JOBS_UNSAFE= yes @@ -62,12 +61,6 @@ PLIST_SUB+= WITH_TKMIB="" .endif -.if defined(WITH_PYTHON) -CONFIGURE_ARGS+=--with-python-modules -BUILD_DEPENDS+= easy_install:${PORTSDIR}/devel/py-setuptools -BUILD_DEPENDS+= python:${PORTSDIR}/lang/python -.endif - .if defined(WITH_PERL) USE_PERL5= yes CONFIGURE_ARGS+=--with-perl-modules Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->sylvio Over to maintainer (via the GNATS Auto Assign Tool)
Hi, Geoffrey. A couple of comments: a) you sent reversed patch - it doesn't tries to add something, but tries to remove not yet existing python support from Makefile. b) use "USE_PYTHON= yes" and "USE_PYDISTUTILS= easy_install" instead of BUILD_DEPENDS to depend on python and setuptools respectively. Regards, Ruslan Tinderboxing kills... the drives.
Responsible Changed From-To: sylvio->scheidell i'll take it, sylvio on leave http://www.freebsd.org/cgi/query-pr.cgi?pr=162140 Alternate patch: Index: Makefile =================================================================== RCS file: /home/pcvs/ports/net-mgmt/net-snmp/Makefile,v retrieving revision 1.197 diff -u -u -r1.197 Makefile --- Makefile 2 Dec 2011 13:46:09 -0000 1.197 +++ Makefile 3 Dec 2011 19:17:55 -0000 @@ -23,7 +23,8 @@ DUMMY "Enable dummy values as placeholders" on \ TKMIB "Install graphical MIB browser" off \ DMALLOC "Enable dmalloc debug memory allocator" off \ - UNPRIVILEGED "Allow unprivileged users to execute net-snmp" off + UNPRIVILEGED "Allow unprivileged users to execute net-snmp" off \ + PYTHON "Install python bindings off MAKE_JOBS_UNSAFE= yes @@ -46,6 +47,12 @@ CONFIGURE_ARGS+=--with-defaults .endif +.if defined(WITH_PYTHON) +CONFIGURE_ARGS+= --with-python-modules +USE_PYTHON= yes +USE_PYDISTUTILS= easy_install +.endif + .include <bsd.port.pre.mk> CONFIGURE_ARGS+= --with-openssl="${OPENSSLBASE}"
State Changed From-To: open->feedback Alternate patch, awaiting maintainers feedback
State Changed From-To: feedback->closed Committed with changes,thanks committer change: make python option off by default makes this a 'noop' for current installs, keeps upward compatibility
scheidell 2011-12-14 13:08:08 UTC FreeBSD ports repository Modified files: net-mgmt/net-snmp Makefile Log: - re-integration which enables the option of building the python bindings [1] - with the addition of a options knob (off by default) - No portsbump so that its a 'noop' for systems that don't need python bindings PR: ports/162140 Submitted by: Geoffrey Huntley <ghuntley@ghuntley.com> [1] Approved by: zi (maintainer timeout, 30 days), gabor (mentor) Revision Changes Path 1.199 +8 -1 ports/net-mgmt/net-snmp/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
scheidell 2011-12-14 21:16:45 UTC FreeBSD ports repository Modified files: net-mgmt/net-snmp Makefile Log: - Backed out at request of maintainer - PR reopened PR: ports/162140 Approved by: zi (maintainer) Revision Changes Path 1.201 +1 -8 ports/net-mgmt/net-snmp/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: closed->feedback Maintainer reports this patch would not address issue. Reopened. Committer should address issues with maintainer
Responsible Changed From-To: scheidell->zi I'll take it.
State Changed From-To: feedback->analyzed I'm currently testing a patch that will add Python support. Additional work is still required, but is in progress.
zi 2012-02-12 00:27:04 UTC FreeBSD ports repository Modified files: net-mgmt/net-snmp Makefile pkg-plist Log: - Add support to build/install the net-snmp python modules PR: ports/162140 Requested by: Geoffrey Huntley <ghuntley@ghuntley.com> Revision Changes Path 1.204 +37 -0 ports/net-mgmt/net-snmp/Makefile 1.61 +3 -0 ports/net-mgmt/net-snmp/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Python support has been added. You must update your ports tree and run 'make config' to enable it.