/usr/ports/multimedia/libxine/Makefile: Checks for CFLAGS less than -O1 but rejects recent gcc optimization levels such as -Os, which incorrectly triggers an IGNORE prompting for at least an -O1. Please include newer gcc optimization levels in this test as current workarounds are messy to deal with. P.S.: Makefile is 11 years old?? Fix: Simple boolean logic involved here... I suggest a blacklist instead of a whitelist here, which only complicates the testing here. How-To-Repeat: Build multimedia/libxine with CFLAGS=-Os
Responsible Changed From-To: freebsd-ports-bugs->nox Over to maintainer (via the GNATS Auto Assign Tool)
nox 2011-10-31 20:55:56 UTC FreeBSD ports repository Modified files: multimedia/libxine Makefile Log: Generalize optimization sanity check so that levels like -Os are accepted too. PR: ports/162204 Submitted by: Samuel Duclos <wiseakasha@hotmail.com> Revision Changes Path 1.175 +2 -1 ports/multimedia/libxine/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Fix committed. Thanks!