Bug 162378 - x11/yakuake-kde4 doesn't honor WITHOUT_NLS
Summary: x11/yakuake-kde4 doesn't honor WITHOUT_NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 15:50 UTC by Gleb Popov
Modified: 2011-12-20 21:10 UTC (History)
0 users

See Also:


Attachments
file.txt (4.72 KB, text/plain)
2011-11-08 15:50 UTC, Gleb Popov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Popov freebsd_committer freebsd_triage 2011-11-08 15:50:08 UTC
Since there is no way to change language in yakuake itself, i've hacked a CMake build not to install .po files if WITHOUT_NLS is defined.
I've done it same way as in devel/tortoisehg2 port.

I'm not sure about commenting find_package(Msgfmt ...) line, though.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-08 15:50:16 UTC
Maintainer of x11/yakuake-kde4,

Please note that PR ports/162378 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162378

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-08 15:50:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Shane Bell 2011-12-04 06:43:53 UTC
Approved, thanks.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-12-04 10:18:39 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2011-12-06 18:13:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 6 Michael Scheidell freebsd_committer freebsd_triage 2011-12-07 09:35:59 UTC
Responsible Changed
From-To: scheidell->freebsd-ports-bugs

runaway process on dependency. 
9-scheidell 	x11/yakuake-kde4 	phonon-4.5.1 	5:36:28 	N/A 

phonon wants to take 5 hours to compile in tinderbox. 
back to pool.
Comment 7 Pawel Pekala freebsd_committer freebsd_triage 2011-12-19 21:22:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 8 dfilter service freebsd_committer freebsd_triage 2011-12-20 21:07:36 UTC
pawel       2011-12-20 21:07:27 UTC

  FreeBSD ports repository

  Modified files:
    x11/yakuake-kde4     Makefile pkg-plist 
  Added files:
    x11/yakuake-kde4/files patch-CMakeLists.txt 
  Log:
  - Support WITHOUT_NLS knob [1]
  - Add INSTALLS_ICONS=yes
  
  PR:             ports/162378 [1]
  Submitted by:   arrowdodger <6yearold@gmail.com> [1]
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.22      +15 -0     ports/x11/yakuake-kde4/Makefile
  1.1       +12 -0     ports/x11/yakuake-kde4/files/patch-CMakeLists.txt (new)
  1.11      +33 -33    ports/x11/yakuake-kde4/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Pawel Pekala freebsd_committer freebsd_triage 2011-12-20 21:08:39 UTC
State Changed
From-To: open->closed

Committed. Thanks!