Bug 162602 - devel/st [patch] event.c missing from work/st-1.9/Makefile
Summary: devel/st [patch] event.c missing from work/st-1.9/Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Felippe de Meirelles Motta
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 00:20 UTC by Mark Delany
Modified: 2013-02-07 19:29 UTC (History)
0 users

See Also:


Attachments
file.diff (396 bytes, patch)
2011-11-16 00:20 UTC, Mark Delany
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Delany 2011-11-16 00:20:06 UTC
The 1.9 version of state threads introduced a new source module called event.c

It looks like that module name has not been added to the SRCS take in the Makefile

The library still builds as event.c only presents user APIs and is not used by any other part of the st library, however the library is unusable by applications because of the missing entry-points.

Fix: 3# diff -c files/Makefile.main.orig files/Makefile.main
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-16 00:20:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lippe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-15 04:46:25 UTC
Responsible Changed
From-To: lippe->pgollucci

committer&maintainer timeout (lippe ; 91 days) / last commit: 198 days 
ago
Comment 3 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2012-04-05 21:43:45 UTC
Responsible Changed
From-To: pgollucci->lippe

I'll take it.
Comment 4 Mark Delany 2012-12-08 04:17:10 UTC
Hi Folks.

Just following up on this report.

In the original report I included the patch to fix the port about a
year ago and it's not yet in the ports repo. Is there something I can
do to help move this along?


Mark.


On 16Nov11, FreeBSD-gnats-submit@FreeBSD.org allegedly wrote:
> Thank you very much for your problem report.
> It has the internal identification `ports/162602'.
> The individual assigned to look at your
> report is: freebsd-ports-bugs. 
> 
> You can access the state of your problem report at any time
> via this link:
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=162602
> 
> >Category:       ports
> >Responsible:    freebsd-ports-bugs
> >Synopsis:       event.c missing from ports/devel/st/work/st-1.9/Makefile
> >Arrival-Date:   Wed Nov 16 00:20:06 UTC 2011
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-02-07 19:18:03 UTC
Author: lippe
Date: Thu Feb  7 19:17:55 2013
New Revision: 311880
URL: http://svnweb.freebsd.org/changeset/ports/311880

Log:
  - Fix Makefile to install event module recently added
  - Make portlint happy
  
  PR:		ports/162602, ports/173447
  Submitted by:	Mark Delany <z2n@delta.emu.st>, Kevin Day <kevin@your.org>

Modified:
  head/devel/st/Makefile   (contents, props changed)
  head/devel/st/files/Makefile.main   (contents, props changed)

Modified: head/devel/st/Makefile
==============================================================================
--- head/devel/st/Makefile	Thu Feb  7 19:07:07 2013	(r311879)
+++ head/devel/st/Makefile	Thu Feb  7 19:17:55 2013	(r311880)
@@ -1,12 +1,10 @@
-# New ports collection makefile for:    st
-# Date created:         Sun Feb 18 2001
-# Whom:                 tobez@tobez.org
-#
+# Created by: tobez
 # $FreeBSD$
 #
 
 PORTNAME=	st
 PORTVERSION=	1.9
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	SF/${PORTNAME}ate-threads/${PORTNAME}ate-threads/${PORTVERSION}
 
@@ -30,9 +28,11 @@ post-patch:
 
 post-install:
 	@${CP} ${WRKSRC}/public.h ${PREFIX}/include/st.h
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 	@${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/docs/,} ${DOCSDIR}/
+.endif
+.if ${PORT_OPTIONS:MEXAMPLES}
 	@${MKDIR} ${EXAMPLESDIR}
 	@${INSTALL_DATA} ${EXAMPLES:S,^,${WRKSRC}/examples/,} ${EXAMPLESDIR}/
 .endif

Modified: head/devel/st/files/Makefile.main
==============================================================================
--- head/devel/st/files/Makefile.main	Thu Feb  7 19:07:07 2013	(r311879)
+++ head/devel/st/files/Makefile.main	Thu Feb  7 19:17:55 2013	(r311880)
@@ -8,7 +8,7 @@ SHLIB_MINOR=	1
 LIB=		st
 NO_PROFILE=	yes
 
-SRCS=		io.c key.c sched.c stk.c sync.c
+SRCS=		io.c key.c sched.c stk.c sync.c event.c
 CFLAGS+=	-DFREEBSD
 
 .include <bsd.lib.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2013-02-07 19:29:07 UTC
State Changed
From-To: open->closed

Committed. Thanks!