A new version has been released Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->rene rene@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of emulators/wine-gecko, Please note that PR ports/162678 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162678 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I approve this change
The update itself looks OK, but ports-mgmt/portlint complains that the LICENSE section has to be moved up (between the COMMENT and NO_BUILD lines): % pwd /usr/home/rene/freebsd/ports/emulators/wine-gecko % portlint -C WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. FATAL: Makefile: extra item "NO_BUILD" placed in the LICENSE section. FATAL: Makefile: extra item "PLIST_SUB" placed in the LICENSE section. FATAL: Makefile: extra item "DATADIR" placed in the LICENSE section. FATAL: Makefile: extra item "PLIST_FILES" placed in the LICENSE section. FATAL: Makefile: extra item "PLIST_DIRSTRY" placed in the LICENSE section. WARN: Makefile: "LICENSE_COMB" has to appear earlier. WARN: Makefile: "LICENSE" has to appear earlier. WARN: Makefile: "LICENSE_COMB" has to appear earlier. 5 fatal errors and 4 warnings found. Is it OK to do this? That would result in only the (superfluous) first warning appearing.
On Sunday, 20 November 2011 17:36:10 Rene Ladan wrote: > The update itself looks OK, but ports-mgmt/portlint complains that the > LICENSE section has to be moved up (between the COMMENT and NO_BUILD > lines): > > % pwd > /usr/home/rene/freebsd/ports/emulators/wine-gecko > % portlint -C > WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX > and/or PKGNAMESUFFIX. > FATAL: Makefile: extra item "NO_BUILD" placed in the LICENSE section. > FATAL: Makefile: extra item "PLIST_SUB" placed in the LICENSE section. > FATAL: Makefile: extra item "DATADIR" placed in the LICENSE section. > FATAL: Makefile: extra item "PLIST_FILES" placed in the LICENSE section. > FATAL: Makefile: extra item "PLIST_DIRSTRY" placed in the LICENSE section. > WARN: Makefile: "LICENSE_COMB" has to appear earlier. > WARN: Makefile: "LICENSE" has to appear earlier. > WARN: Makefile: "LICENSE_COMB" has to appear earlier. > 5 fatal errors and 4 warnings found. > > Is it OK to do this? That would result in only the (superfluous) first > warning appearing. Yes, I am fine with that
rene 2011-11-20 17:14:34 UTC FreeBSD ports repository Modified files: emulators/wine-gecko Makefile distinfo Log: - Update to 1.4 [1] - Pet portlint by moving LICENSE section [2] PR: ports/162678 [1] Submitted by: Barbara [barbara.xxx1975 libero/it] [2] Submitted by: myself [2] Approved by: maintainer [1] [2] Feature safe: yes Revision Changes Path 1.4 +4 -4 ports/emulators/wine-gecko/Makefile 1.3 +2 -2 ports/emulators/wine-gecko/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks