Bug 162783 - [PATCH] www/nginx: add third party module NAXSI
Summary: [PATCH] www/nginx: add third party module NAXSI
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sergey A. Osokin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 11:40 UTC by Xavier Beaudouin
Modified: 2011-12-29 07:20 UTC (History)
1 user (show)

See Also:

Attachments
nginx-1.0.10,1.patch (2.03 KB, patch)
2011-11-23 11:40 UTC, Xavier Beaudouin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Beaudouin 2011-11-23 11:40:07 UTC 
Added 3rd party module Naxsi : http://code.google.com/p/naxsi/

And fixed space separated variables that should be tab separated.

Port maintainer (osa@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-23 11:40:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->osa

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Sofian Brabez freebsd_committer freebsd_triage 2011-11-25 00:26:24 UTC 
Hi,

Please consider the little modification adjustement in this ports located at [1]
for ports www/nginx and [2] for www/nginx-devel in order to follow FreeBSD ports
rules.

Also, builds seems OK and tinderbox builds are scheduled [3], have a look to
[4].

Regards

[1] http://people.freebsd.org/~sbz/nginx-naxsi/nginx-naxsi.diff
[2] http://people.freebsd.org/~sbz/nginx-naxsi/nginx-naxsi-devel.diff
[3] http://regis.goodking.ca/tb/index.php?action=list_tinderd_queue
[4] http://people.freebsd.org/~sbz/nginx-naxsi/

--
Sofian Brabez
Comment 3 Xavier Beaudouin 2011-11-28 10:31:32 UTC 
Hi Sofian,

On Fri, 25 Nov 2011 01:26:24 +0100, Sofian Brabez wrote:
> Hi,
>
> Please consider the little modification adjustement in this ports
> located at [1]
> for ports www/nginx and [2] for www/nginx-devel in order to follow
> FreeBSD ports
> rules.
>
> Also, builds seems OK and tinderbox builds are scheduled [3], have a 
> look to
> [4].

I am totaly ok with the modification you made :) And if you are ok, 
there is no issues for me that you commit the adjustements you made on 
my modifications :)

Kind regards,
Xavier

-- 
Xavier Beaudouin
Comment 4 Sergey A. Osokin freebsd_committer freebsd_triage 2011-12-12 13:40:57 UTC 
Could you please resend you patch with following modifications:

1) downstairs description of new module, right after memc in OPTIONS;
2) remove needless changes for xrid_header module;
3) do make makesum because it looks like you are just add two strings into distinfo file;
4) also add some logic for directories of your "security" module (i.e. ${ETCDIR}/bla-bla-bla)

Thank you.
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-12-29 07:15:44 UTC 
osa         2011-12-29 07:15:30 UTC

  FreeBSD ports repository

  Modified files:
    www/nginx            Makefile distinfo 
    www/nginx-devel      Makefile distinfo 
  Log:
  Add naxsi third-party module, version 0.42.
  Move down checksums for devel_kit third-party module.
  Do not bump PORTREVISION because these modules disabled by default.
  
  PR:     162783
  
  Revision  Changes    Path
  1.416     +20 -0     ports/www/nginx-devel/Makefile
  1.364     +4 -2      ports/www/nginx-devel/distinfo
  1.293     +21 -0     ports/www/nginx/Makefile
  1.254     +2 -0      ports/www/nginx/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Sergey A. Osokin freebsd_committer freebsd_triage 2011-12-29 07:20:18 UTC 
State Changed
From-To: open->closed

Committed with some modifications, thanks for report!