Bug 162790 - x11-wm/i3 does not install all necessary files
Summary: x11-wm/i3 does not install all necessary files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dennis Herrmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 16:50 UTC by Peter
Modified: 2011-11-28 11:30 UTC (History)
0 users

See Also:


Attachments
file.txt (825 bytes, text/plain)
2011-11-23 16:50 UTC, Peter
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2011-11-23 16:50:05 UTC
The latest x11-wm/i3 port does not install all the necessary files/scripts.

From http://i3wm.org/downloads/RELEASE-NOTES-4.1.txt:
 Introduce the i3-sensible-{pager,editor,terminal} scripts to execute
    $PAGER, $EDITOR or an available terminal emulator

These are not installed and causes i3 to not fully work. In my case, i3 was non responsive at all and required a kill.
I've copied them manually from the work directory of the port or local/bin/ and everything works fine.


Missing files afaik are:
work/i3-4.1/i3-sensible-editor
work/i3-4.1/i3-sensible-pager
work/i3-4.1/i3-sensible-terminal
 and their man pages.

Fix: Manually copy the files from work ${WRKSRC} or patch Makefile:
I've attached a diff of my "hacked" Makefile, it seems to work.

/usr/ports/x11-wm/i3/work/i3-4.1/Makefile lists all the needed files, and running gmake in that dir installs them but to /bin instead of local/bin:

install: all
        echo "[i3] INSTALL"
        $(INSTALL) -d -m 0755 $(DESTDIR)$(PREFIX)/bin
        $(INSTALL) -d -m 0755 $(DESTDIR)$(SYSCONFDIR)/i3
        $(INSTALL) -d -m 0755 $(DESTDIR)$(PREFIX)/include/i3
        $(INSTALL) -d -m 0755 $(DESTDIR)$(PREFIX)/share/xsessions
        $(INSTALL) -m 0755 i3 $(DESTDIR)$(PREFIX)/bin/
        $(INSTALL) -m 0755 i3-migrate-config-to-v4 $(DESTDIR)$(PREFIX)/bin/
        $(INSTALL) -m 0755 i3-sensible-editor $(DESTDIR)$(PREFIX)/bin/
        $(INSTALL) -m 0755 i3-sensible-pager $(DESTDIR)$(PREFIX)/bin/
        $(INSTALL) -m 0755 i3-sensible-terminal $(DESTDIR)$(PREFIX)/bin/
        test -e $(DESTDIR)$(SYSCONFDIR)/i3/config || $(INSTALL) -m 0644 i3.config $(DESTDIR)$(SYSCONFDIR)/i3/config
        test -e $(DESTDIR)$(SYSCONFDIR)/i3/config.keycodes || $(INSTALL) -m 0644 i3.config.keycodes $(DESTDIR)$(SYSCONFDIR)/i3/co
nfig.keycodes
        $(INSTALL) -m 0644 i3.welcome $(DESTDIR)$(SYSCONFDIR)/i3/welcome
        $(INSTALL) -m 0644 i3.desktop $(DESTDIR)$(PREFIX)/share/xsessions/
        $(INSTALL) -m 0644 include/i3/ipc.h $(DESTDIR)$(PREFIX)/include/i3/
        for dir in $(SUBDIRS); do \
                $(MAKE) -C $$dir install; \
        done


Patch attached with submission follows:
How-To-Repeat: # pwd
/usr/ports/x11-wm/i3
# make install
===>  Installing for i3-4.1
===>   i3-4.1 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found
===>   i3-4.1 depends on file: /usr/local/libdata/xorg/libraries - found
===>   i3-4.1 depends on shared library: xcb.2 - found
===>   i3-4.1 depends on shared library: startup-notification-1.0 - found
===>   i3-4.1 depends on shared library: xcb-event.1 - found
===>   i3-4.1 depends on shared library: ev.4 - found
===>   i3-4.1 depends on shared library: yajl.1 - found
===>   i3-4.1 depends on shared library: iconv.3 - found
===>   Generating temporary packing list
===>  Checking if x11-wm/i3 already installed
install  -o root -g wheel -m 555 /data/ports/x11-wm/i3/work/i3-4.1/i3 /usr/local/bin/
install  -o root -g wheel -m 555 /data/ports/x11-wm/i3/work/i3-4.1/i3-config-wizard/i3-config-wizard /usr/local/bin/
install  -o root -g wheel -m 555 /data/ports/x11-wm/i3/work/i3-4.1/i3-input/i3-input /usr/local/bin/
install  -o root -g wheel -m 555 /data/ports/x11-wm/i3/work/i3-4.1/i3-msg/i3-msg /usr/local/bin/
install  -o root -g wheel -m 555 /data/ports/x11-wm/i3/work/i3-4.1/i3-nagbar/i3-nagbar /usr/local/bin/
install  -o root -g wheel -m 555 /data/ports/x11-wm/i3/work/i3-4.1/i3bar/i3bar /usr/local/bin/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/config.sample /usr/local/etc/i3
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/welcome /usr/local/etc/i3/welcome
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3-config-wizard.1 /usr/local/man/man1/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3-input.1 /usr/local/man/man1/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3-migrate-config-to-v4.1 /usr/local/man/man1/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3-msg.1 /usr/local/man/man1/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3-nagbar.1 /usr/local/man/man1/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3-wsbar.1 /usr/local/man/man1/
install  -o root -g wheel -m 444 /data/ports/x11-wm/i3/work/i3-4.1/man/i3.1 /usr/local/man/man1/
======================================================================================

        i3 need a config file! A example do you found on /usr/local/etc/i3
        Please rename it in /usr/local/etc/i3/config
        For more information read the manpage :)

======================================================================================
===>   Compressing manual pages for i3-4.1
===>   Registering installation for i3-4.1
===> SECURITY REPORT:
      This port has installed the following files which may act as network
      servers and may therefore pose a remote security risk to the system.
/usr/local/bin/i3

      If there are vulnerabilities in these programs there may be a security
      risk to the system. FreeBSD makes no guarantee about the security of
      ports included in the Ports Collection. Please type 'make deinstall'
      to deinstall the port if this is a concern.

      For more information, and contact details about the security
      status of this software, see the following webpage:
http://i3wm.org
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-11-23 19:01:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dhn

Fix synopsis and assign.
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-11-28 11:24:01 UTC
dhn         2011-11-28 11:23:48 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/i3            Makefile 
  Log:
  - Fix do-install
  - Remove USE_XLIB
  - Bump PORTREVISION
  
  PR:             ports/162790
  Submitted by:   Peter <fbsdq@peterk.org>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.18      +11 -3     ports/x11-wm/i3/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dennis Herrmann freebsd_committer freebsd_triage 2011-11-28 11:24:22 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!