Bug 162903 - textproc/grap port upgrade from maintainer
Summary: textproc/grap port upgrade from maintainer
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Carlo Strub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-27 04:00 UTC by faber
Modified: 2011-12-01 21:20 UTC (History)
0 users

See Also:


Attachments
file.diff (889 bytes, patch)
2011-11-27 04:00 UTC, faber
no flags Details | Diff
grap-1.44.log (10.42 KB, application/octet-stream)
2011-11-29 00:14 UTC, Carlo Strub
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description faber 2011-11-27 04:00:23 UTC
	New grap port.  Port diff (diff -ruN) attached.

How-To-Repeat: 	N/A
Comment 1 Carlo Strub freebsd_committer freebsd_triage 2011-11-28 23:54:42 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cs

I'll take it.
Comment 2 Carlo Strub freebsd_committer freebsd_triage 2011-11-29 00:14:31 UTC
There is an error when installing this port with NOPORTDOCS set. The port still installs documents although it should not. See the log file attached. Please fix it and resubmit.

--
Carlo Strub
Ports committer
--=
Comment 3 Carlo Strub freebsd_committer freebsd_triage 2011-11-29 00:23:35 UTC
State Changed
From-To: open->feedback

wait for new patch
Comment 4 Carlo Strub freebsd_committer freebsd_triage 2011-11-29 09:19:17 UTC
Your proposed change is not optimal. We definitely do want people to choose=
 whether they want to install docs or not, hence it is good policy to use "=
.if !defined(NOPORTDOCS)" in your Makefile. The only error with your first =
patch was that this was not respected and docs were still installed. Can yo=
u please give it another try. Please check also the porter's handbook for a=
dvice.

Btw, if you use portlint -CA, you will get such a complaint as well.

Many thanks,
Carlo=
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-12-01 21:12:49 UTC
cs          2011-12-01 21:12:36 UTC

  FreeBSD ports repository

  Modified files:
    textproc/grap        Makefile distinfo 
  Log:
  Update to 1.44
  
  PR:             ports/162903
  Submitted by:   Ted Faber <faber@lunabase.org> (maintainer)
  Approved by:    glarkin@ (mentor)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.32      +4 -3      ports/textproc/grap/Makefile
  1.30      +2 -2      ports/textproc/grap/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Carlo Strub freebsd_committer freebsd_triage 2011-12-01 21:13:03 UTC
State Changed
From-To: feedback->closed

Committed. Thank you very much.