Bug 163066 - [patch] bsd.database.mk: Allow db5 to be selected by USE_BDB=4X+
Summary: [patch] bsd.database.mk: Allow db5 to be selected by USE_BDB=4X+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-04 18:40 UTC by Yuri Pankov
Modified: 2013-02-06 23:30 UTC (History)
0 users

See Also:


Attachments
bsd.database.mk.diff (364 bytes, patch)
2011-12-04 18:40 UTC, Yuri Pankov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Pankov 2011-12-04 18:40:05 UTC
Currently ports specifying USE_BDB=4X+ don't get db5 as a valid selection and try to install respective databases/db4X port. This could be "fixed" by using WITH_BDB_VER=5, but it would be nice to allow using the installed db port without requiring additional options.
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2011-12-08 02:44:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2011-12-08 03:06:50 UTC
State Changed
From-To: open->analyzed

wait for slush
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2012-02-13 05:19:43 UTC
State Changed
From-To: analyzed->open

this should have been opened a while ago
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2012-04-12 04:09:09 UTC
Responsible Changed
From-To: eadler->freebsd-ports-bugs

there is more going on here than meets the eye
Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-04-12 21:17:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2012-04-12 21:35:46 UTC
Hi Yuri,

thanks for the contribution, but I think we're not ready for this change
yet. In fact, I made exactly the opposite change (opposite to what you
are proposing), a couple of months ago, because the INVALID_BDB_VER and
the version harvesting altogether, are not up to the job.

I think we have several version-dependency frameworks in place that are
more expressive than Berkeley DB's, and I'd like to see one of those
adopted.

Before we go that way, I'd propose to cut down on the number of Berkeley
DB ports altogether.  I don't think we need more than two, perhaps three
versions in the ports tree.

Best regards,
Matthias
Comment 7 Chris Rees freebsd_committer freebsd_triage 2012-04-12 21:37:20 UTC
State Changed
From-To: open->suspended

More preparation required before this goes in; port maintainers need a 
way to specify a maximum version as well. 


Comment 8 Chris Rees freebsd_committer freebsd_triage 2012-04-12 21:37:20 UTC
Responsible Changed
From-To: crees->mandree

Matthias is the bdb maintainer
Comment 9 dfilter service freebsd_committer freebsd_triage 2013-02-06 23:20:46 UTC
Author: mandree
Date: Wed Feb  6 23:20:35 2013
New Revision: 311805
URL: http://svnweb.freebsd.org/changeset/ports/311805

Log:
  Re-enable auto-pickup of Berkeley DB 5.3.
  
  If ports break with db5, they need to be fixed, we want to weed out obsolete
  Berkeley DB versions in the long run.
  
  PR:           ports/163066
  Submitted by: Yuri Pankov <yuri.pankov@gmail.com>

Modified:
  head/Mk/bsd.database.mk

Modified: head/Mk/bsd.database.mk
==============================================================================
--- head/Mk/bsd.database.mk	Wed Feb  6 22:56:48 2013	(r311804)
+++ head/Mk/bsd.database.mk	Wed Feb  6 23:20:35 2013	(r311805)
@@ -317,7 +317,8 @@ _DB_43P=	43 ${_DB_44P}
 _DB_44P=	44 ${_DB_46P}
 _DB_46P=	46 ${_DB_47P}
 _DB_47P=	47 ${_DB_48P}
-_DB_48P=	48
+_DB_48P=	48 ${_DB_5P}
+_DB_5P=		5
 
 # Override the global WITH_BDB_VER with the
 # port specific <UNIQUENAME>_WITH_BDB_VER
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 10 Matthias Andree freebsd_committer freebsd_triage 2013-02-06 23:21:39 UTC
State Changed
From-To: suspended->closed

Committed, thanks. I have reconsidered that if there are ports stating 
db5 were fine but is not, those ports need to be fixed.