Bug 163188 - [patch] net-p2p/amule: broken without /usr/bin/perl symlink
Summary: [patch] net-p2p/amule: broken without /usr/bin/perl symlink
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-11 19:20 UTC by Jan Beich
Modified: 2012-01-29 06:50 UTC (History)
0 users

See Also:


Attachments
perl.diff (666 bytes, patch)
2011-12-11 19:20 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2011-12-11 19:20:03 UTC

How-To-Repeat: $ make install -C $PORTSDIR/lang/perl5.12 WITHOUT_USE_PERL=
$ make install -C $PORTSDIR/net-p2p/amule
===>  Building for amule-2.3.1
[...]
Making all in ec
gmake[4]: Entering directory `/usr/ports/net-p2p/amule/work/aMule-2.3.1/src/libs/ec'
./file_generator.pl . abstracts/ECTagTypes.abstract abstracts/ECCodes.abstract;
./file_generator.pl: not found
gmake[4]: *** [ECGeneratedFiles] Error 127
gmake[4]: Leaving directory `/usr/ports/net-p2p/amule/work/aMule-2.3.1/src/libs/ec'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/net-p2p/amule/work/aMule-2.3.1/src/libs'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/net-p2p/amule/work/aMule-2.3.1/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/net-p2p/amule/work/aMule-2.3.1'
gmake: *** [all] Error 2
*** [do-build] Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-11 19:20:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-11 19:20:16 UTC
Maintainer of net-p2p/amule,

Please note that PR ports/163188 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/163188

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-11 19:20:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Jan Beich freebsd_committer freebsd_triage 2011-12-12 10:36:06 UTC
The patch should use ${PERL}, not ${PERL5}. Apparently, bsd.perl.mk
doesn't allow multiple versions similar to

  $ make install PYTHON_VERSION=python3.1
  $ make install RUBY_VER=1.9

--- perl.diff begins here ---
Index: net-p2p/amule/Makefile
===================================================================
RCS file: /a/.csup/ports/net-p2p/amule/Makefile,v
retrieving revision 1.50
diff -u -p -r1.50 Makefile
--- net-p2p/amule/Makefile	30 Nov 2011 21:20:54 -0000	1.50
+++ net-p2p/amule/Makefile	12 Dec 2011 10:24:53 -0000
@@ -218,6 +218,8 @@ PLIST_SUB+=		XAS="@comment "
 		-e 's/test.*-print-file-name.*`/true/' \
 		-e '/if.*test/s/==/=/' \
 		${WRKSRC}/configure
+	${FIND} ${WRKSRC} -name \*.pl -exec ${REINPLACE_CMD} \
+		's|/usr/bin/perl|${PERL}|' {} +
 .if defined(NOPORTDOCS)
 	${REINPLACE_CMD} 's/install-data-am:.*/install-data-am:/' \
 		${WRKSRC}/docs/Makefile.in
--- perl.diff ends here ---
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2012-01-29 06:48:41 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-01-29 06:48:41 UTC
miwi        2012-01-29 06:48:26 UTC

  FreeBSD ports repository

  Modified files:
    net-p2p/amule        Makefile 
  Log:
  - Fix build when perl symlink is missing
  
  PR:             163188
  Submitted by:   Jan Beich <jbeich@tormail.net>
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.57      +2 -0      ports/net-p2p/amule/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"