Bug 163243 - [MAINTAINER-UPDATE] [PATCH] databases/autobackupmysql: bugfix
Summary: [MAINTAINER-UPDATE] [PATCH] databases/autobackupmysql: bugfix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 12:40 UTC by Frank Wall
Modified: 2011-12-24 13:40 UTC (History)
0 users

See Also:


Attachments
file.diff (2.09 KB, patch)
2011-12-13 12:40 UTC, Frank Wall
no flags Details | Diff
patch.txt (2.91 KB, text/plain)
2011-12-15 09:46 UTC, Frank Wall
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Wall 2011-12-13 12:40:04 UTC
small bugfix for databases/autobackupmysql:

- replace GNU sed pattern with BSD equivalent (thanks to Cameron Berkenpas!)
- add my self-hosted mirror dl.moov.de
- bump PORTREVISION

Fix: apply patch to the ports tree

Patch attached with submission follows:
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2011-12-14 12:11:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->zi

I'll take it.
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2011-12-14 12:18:03 UTC
State Changed
From-To: open->feedback

Checksum appears to have changed upstream.  We should identify the cause 
and verify that it is a safe reason and then update the distinfo 
accordingly.  This would be preferred instead of adding a private mirror 
of the previous checksum.o 

From what I can tell, it looks like the version on sourceforge is 1.4 
and the version on your mirror is 1.2.  Based on that, I would recommend 
that we: - Bump PORTVERSION to 1.4 - Remove PORTREVISION - Have you 
update your patches to apply against 1.4 (if they don't already) - 
Update distinfo to reflect version 1.4 

Please let me know if you agree/disagree.  Thanks! 

-r 

=> autobackupmysql.sh doesn't seem to exist in /usr/ports/distfiles/. 
=> Attempting to fetch 
http://heanet.dl.sourceforge.net/project/autobackupmysql/autobackupmysql.sh 
fetch: 
http://heanet.dl.sourceforge.net/project/autobackupmysql/autobackupmysql.sh: 
size mismatch: expected 22011, actual 22746 => Attempting to fetch 
http://sunet.dl.sourceforge.net/project/autobackupmysql/autobackupmysql.sh 
fetch: 
http://sunet.dl.sourceforge.net/project/autobackupmysql/autobackupmysql.sh: 
size mismatch: expected 22011, actual 22746 => Attempting to fetch 
http://iweb.dl.sourceforge.net/project/autobackupmysql/autobackupmysql.sh 
fetch: 
http://iweb.dl.sourceforge.net/project/autobackupmysql/autobackupmysql.sh: 
size mismatch: expected 22011, actual 22746
Comment 3 Frank Wall 2011-12-14 12:47:47 UTC
Hi,

> From what I can tell, it looks like the version on sourceforge is 1.4
> and the version on your mirror is 1.2.  Based on that, I would 
> recommend
> that we: - Bump PORTVERSION to 1.4 - Remove PORTREVISION

you're right about this, I've forgotten this version update. Please 
proceed.
(I've updated the files on my local mirror too.)

> - Have you update your patches to apply against 1.4 (if they don't 
> already)
> - Update distinfo to reflect version 1.4

I've tested the patch against version 1.4 and it still applies cleanly,
so please proceed.


Thanks
- Frank
Comment 4 Frank Wall 2011-12-15 09:46:27 UTC
Am 15.12.2011 01:59, schrieb Ryan Steinmetz:
> Patch seems to fail for me.  This is the output of the reject file:

Thanks for your persistence. Silly me. Attached you will find a new
patch hopefully fixing everything:

- bump PORTVERSION to 1.4
- rmove PORTREVISION
- update patch
- update distinfo


Thanks
- Frank
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-12-24 13:35:44 UTC
zi          2011-12-24 13:35:30 UTC

  FreeBSD ports repository

  Modified files:
    databases/autobackupmysql Makefile distinfo 
    databases/autobackupmysql/files patch-autobackupmysql.sh 
  Log:
  - Update to 1.4
  - Honor custom LOCALBASE/PREFIX
  
  PR:             ports/163243
  Submitted by:   Frank Wall <fw@moov.de> (maintainer)
  
  Revision  Changes    Path
  1.2       +5 -5      ports/databases/autobackupmysql/Makefile
  1.3       +2 -2      ports/databases/autobackupmysql/distinfo
  1.2       +20 -14    ports/databases/autobackupmysql/files/patch-autobackupmysql.sh
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Ryan Steinmetz freebsd_committer freebsd_triage 2011-12-24 13:35:48 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!