The port did not fetch the distfile any more (ULR does not exist) and it had a build warning with sys/sysctl.h: uptime_freebsd.c: In function 'get_uptime': uptime_freebsd.c:31: warning: passing argument 4 of 'sysctl' from incompatible pointer type Could someone please have a look at my patch for src/uptime_freebsd.c? Unfortunately I have almost no C knowledge, thanks. Renaming files/patch-src_main.c to files/patch-src__main.c because of naming conventions. Fix: Patch attached with submission follows: How-To-Repeat: 1. Try to fetch the distfile without the patch. 2. When building look for the warning.
A warning is usually just a warning, you will see many of these when you build FreeBSD source. If the patch corrects something in the upstream, maybe you could submit it to them so they can properly QA it? If you are willing to approve this update without the patches, I think they can be committed pretty quickly, but these patches would need some time to doublecheck it doesn't open a security/buffer/stack problem. -- Michael Scheidell, CTO o: 561-999-5000 d: 561-948-2259 >*| *SECNAP Network Security Corporation * Best Mobile Solutions Product of 2011 * Best Intrusion Prevention Product * Hot Company Finalist 2011 * Best Email Security Product * Certified SNORT Integrator
On 22.12.2011 14:20 (UTC+1), Michael Scheidell wrote: > A warning is usually just a warning, you will see many of these when you > build FreeBSD source. Yes, I am aware of this. Erroneously I misspelled the build warning as build error, sorry for that. > If the patch corrects something in the upstream, maybe you could submit > it to them so they can properly QA it? Hmm, I am afraid, there is no upstream support for years now :-( > If you are willing to approve this update without the patches, I think > they can be committed pretty quickly, but these patches would need some > time to doublecheck it doesn't open a security/buffer/stack problem. It is only src/update_freebsd.c which I changed because of the warning. The patchfile for src/main.c was only renamed from patch-src_main.c to patch-src__main.c (double underscore). I personally can live without the patch of src/update_freebsd.c, so I would be pleased if you would commit it. Thanks for taking this PR up, Rainer
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->closed Committed with changes. Did not apply patch to quiet warning, did not rename file (no need now)
scheidell 2011-12-23 12:35:04 UTC FreeBSD ports repository Modified files: sysutils/wmupmon Makefile Log: - Fix Source URL PR: ports/163367 Submitted by: Rainer Hurling <rhurlin@gwdg.de> Approved by: gabor (mentor) Revision Changes Path 1.18 +2 -1 ports/sysutils/wmupmon/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"