Bug 163465 - audio/libaacplus fails with FORCE_MAKE_JOBS
Summary: audio/libaacplus fails with FORCE_MAKE_JOBS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 01:50 UTC by T.J.
Modified: 2012-02-06 18:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description T.J. 2011-12-20 01:50:08 UTC
I emailed the maintainer but he was unable to understand the problem due to a language barrier.

~ $ portmaster audio/libaacplus

===>>> Currently installed version: libaacplus-2.0.2_1
===>>> Port directory: /usr/ports/audio/libaacplus

===>>> Gathering distinfo list for installed ports

===>>> Launching 'make checksum' for audio/libaacplus in background
===>>> Gathering dependency list for audio/libaacplus from ports
===>>> Initial dependency check complete for audio/libaacplus

===>>> Starting build for audio/libaacplus <<<===

===>>> All dependencies are up to date

===>  Cleaning for libaacplus-2.0.2_1

===>  License check disabled, port has not defined LICENSE
===>  Found saved configuration for libaacplus-2.0.2_1===>  Extracting for libaacplus-2.0.2_1
=> SHA256 Checksum OK for libaacplus-2.0.2.tar.gz.
=> SHA256 Checksum OK for 26410-800.zip.
===>   libaacplus-2.0.2_1 depends on executable: unzip - found
===>  Patching for libaacplus-2.0.2_1
===>  Applying FreeBSD patches for libaacplus-2.0.2_1
===>   libaacplus-2.0.2_1 depends on executable: unzip - found
===>   libaacplus-2.0.2_1 depends on file: /usr/local/bin/automake-1.11 - found
===>   libaacplus-2.0.2_1 depends on file: /usr/local/bin/autoconf-2.68 - found
===>   libaacplus-2.0.2_1 depends on package: libtool>=2.4 - found
===>   libaacplus-2.0.2_1 depends on executable: pkg-config - found
===>   libaacplus-2.0.2_1 depends on shared library: fftw3 - found
===>   libaacplus-2.0.2_1 depends on shared library: fftw3f - found
===>  Configuring for libaacplus-2.0.2_1
configure.ac:12: installing `./compile'
configure.ac:17: installing `./config.guess'
configure.ac:17: installing `./config.sub'
configure.ac:6: installing `./install-sh'
configure.ac:6: installing `./missing'
frontend/Makefile.am: installing `./depcomp'
Makefile.am: installing `./INSTALL'
checking for a BSD-compatible install... /usr/bin/install -c -o root -g wheel
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... nawk
checking whether make sets $(MAKE)... yes
checking for gcc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of cc... gcc3
checking whether cc understands -c and -o together... yes
checking how to run the C preprocessor... cpp
checking whether ln -s works... yes
checking whether make sets $(MAKE)... (cached) yes
checking build system type... i386-portbld-freebsd8.2
checking host system type... i386-portbld-freebsd8.2
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by cc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... (cached) 262144
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... no
checking how to convert i386-portbld-freebsd8.2 file names to i386-portbld-freebsd8.2 format... func_convert_file_noop
checking how to convert i386-portbld-freebsd8.2 file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... dlltool
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... no
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from cc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if cc supports -fno-rtti -fno-exceptions... no
checking for cc option to produce PIC... -fPIC -DPIC
checking if cc PIC flag -fPIC -DPIC works... yes
checking if cc static flag -static works... yes
checking if cc supports -c -o file.o... yes
checking if cc supports -c -o file.o... (cached) yes
checking whether the cc linker (/usr/bin/ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... freebsd8.2 ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for unzip... /usr/local/bin/unzip
checking for patch... /usr/bin/patch
checking for /bin/bash... no
checking for bash... /usr/local/bin/bash
checking for parameter expansion string replace capable shell... /usr/local/bin/bash
checking for wget... /usr/local/bin/wget
checking for web downloading command... /usr/local/bin/wget -N
checking for library containing sqrt... -lm
checking for ANSI C header files... (cached) yes
checking float.h usability... yes
checking float.h presence... yes
checking for float.h... yes
checking for memory.h... (cached) yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for an ANSI C-conforming const... yes
checking for int16_t... yes
checking for int32_t... yes
checking for int8_t... yes
checking for uint16_t... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for working memcmp... yes
checking for floor... yes
checking for memmove... yes
checking for memset... yes
checking for pow... yes
checking for sqrt... yes
checking for fftw3 library at /usr/local ... test: x/usr/local/lib: unexpected operator
found at /usr/local 
checking for pkg-config... yes
configure: creating ./config.status
config.status: creating aacplus.spec
config.status: creating aacplus-config
config.status: WARNING:  'aacplus-config.in' seems to ignore the --datarootdir setting
config.status: creating aacplus.pc
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating patches/Makefile
config.status: creating include/Makefile
config.status: creating frontend/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
===>  Building for libaacplus-2.0.2_1
/usr/bin/make  all-recursive
Making all in src
make: don't know how to make aacenc.h. Stop
*** Error code 1
1 error
*** Error code 2
1 error
===> Compilation failed unexpectedly.
You have chosen to use multiple make jobs (parallelization) for all ports.
This port was not tested for this setting.  Please remove FORCE_MAKE_JOBS and
retry the build before reporting the failure to the maintainer.
*** Error code 1

Stop in /usr/ports/audio/libaacplus.
*** Error code 1

Stop in /usr/ports/audio/libaacplus.

===>>> make failed for audio/libaacplus
===>>> Aborting update

Terminated

Fix: 

mark MAKE_JOBS_UNSAFE=yes
How-To-Repeat: Install from ports.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-20 01:50:17 UTC
Maintainer of audio/libaacplus,

Please note that PR ports/163465 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/163465

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-20 01:50:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Chris Rees freebsd_committer freebsd_triage 2012-01-05 07:32:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2012-01-16 21:18:13 UTC
2012/1/5 Takefu <takefu@airport.fm>:
>
> I tried the following environments, as was noted.
>
>> FreeBSD RELENG_9 9.0-STABLE FreeBSD 9.0-STABLE #0: Wed Jan =A04 11:50:03=
 JST 2012
>> =A0 =A0 =A0takefu@RELENG_9:/usr/obj/usr/src/sys/GENERIC =A0amd64
>
> amd64 environment was unable to make proper corrections.
> However, this method is not a fundamental solution.
>
> After trying this a patch, please report it.
>
> --- libaacplus.patch begins here ---
> diff -ruN -w /usr/ports/audio/libaacplus/Makefile audio/libaacplus/Makefi=
le
> --- /usr/ports/audio/libaacplus/Makefile =A0 =A0 =A0 =A02011-10-18 16:54:=
09.000000000 +0900
> +++ audio/libaacplus/Makefile =A0 2012-01-05 15:21:17.000000000 +0900
> @@ -21,7 +21,7 @@
> =A0COMMENT=3D =A0 =A0 =A0 HE-AAC+ Codec as Shared Library
>
> =A0EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unzip
> -BUILD_DEPENDS=3D unzip:${PORTSDIR}/archivers/unzip
> +BUILD_DEPENDS:=3D =A0 =A0 =A0 =A0${EXTRACT_DEPENDS}

Hm, these lines aren't necessary;

[crees@pegasus]~/workspace/ports/pcvs/libaacplus% make -dl do-extract
/bin/rm -rf /usr/ports/workspace/pcvs/libaacplus/work
/bin/mkdir -p /usr/ports/workspace/pcvs/libaacplus/work
for file in libaacplus-2.0.2.tar.gz 26410-800.zip; do  if ! (cd
/usr/ports/workspace/pcvs/libaacplus/work && /usr/bin/gzip -nf -9 -dc
/var/distfiles//$file | /usr/bin/tar -xf - --no-same-owner
--no-same-permissions); then  exit 1;  fi;  done
if [ 1001 =3D 0 ]; then  /bin/chmod -R ug-s
/usr/ports/workspace/pcvs/libaacplus/work;  /usr/sbin/chown -R 0:0
/usr/ports/workspace/pcvs/libaacplus/work;  fi

Tar is used to unzip the file, and works just fine.

> =A0RESTRICTED=3D =A0 =A0unclear legal status, probably need licenses from=
 3GPP, Via Licensing and Coding Technologies
>
> @@ -32,6 +32,8 @@
> =A0USE_AUTOTOOLS=3D libtool libtoolize aclocal autoheader automake
> =A0GNOME_MAKEFILEIN=3D =A0 =A0 =A0Makefile.am
> =A0GNU_CONFIGURE=3D yes
> +CONFIGURE_ENV+=3D =A0 =A0 =A0 =A0CC=3Dcc

Is this to address a clang failure?

> +MAKE_JOBS_UNSAFE=3D =A0 =A0 =A0yes
>
> =A0AUTOMAKE_ARGS=3D --add-missing
> =A0ACLOCAL_ARGS=3D =A0--acdir=3D${ACLOCAL_DIR} \
> --- libaacplus.patch ends here ---
>
Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-01-29 20:12:39 UTC
2012/1/17 Takefu <takefu@airport.fm>:
> $B$?$1$U!wBg:eK-Cf$G$9!#(B
> Chris Rees $B$5$s$O=q$-$^$7$?(B (2012/01/17 6:18):
>
>>>  EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip
>>> -BUILD_DEPENDS= unzip:${PORTSDIR}/archivers/unzip
>>> +BUILD_DEPENDS:=        ${EXTRACT_DEPENDS}
>>
>> Hm, these lines aren't necessary;
>
> The configure fails in RELENG_7.
> Will be gradually eliminated.
> Deemed necessary at this time.
>
>>> +CONFIGURE_ENV+=        CC=cc
>>
>> Is this to address a clang failure?
> "clang" does not compile properly.
> Were forced to use a cc.
>
> I do not know how to fix.

Hey Takefu,

I'm really sorry about the delay in getting back to you-- I've been
looking at the port, and I think that marking it MAKE_JOBS_UNSAFE
would be exactly what we need.

Forcing CC in *_ENV isn't needed-- it'll stay on the list of
broken-with-clang ports :)

Is that OK?

Chris

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/libaacplus/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- Makefile    17 Oct 2011 10:08:25 -0000      1.10
+++ Makefile    29 Jan 2012 20:12:14 -0000
@@ -32,6 +32,7 @@
 USE_AUTOTOOLS= libtool libtoolize aclocal autoheader automake
 GNOME_MAKEFILEIN=      Makefile.am
 GNU_CONFIGURE= yes
+MAKE_JOBS_UNSAFE=      yes

 AUTOMAKE_ARGS= --add-missing
 ACLOCAL_ARGS=  --acdir=${ACLOCAL_DIR} \
cvs diff: Diffing files
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-02-06 18:23:46 UTC
crees       2012-02-06 18:23:38 UTC

  FreeBSD ports repository

  Modified files:
    audio/libaacplus     Makefile 
    audio/libaacplus/files patch-configure.ac 
  Added files:
    audio/libaacplus/files patch-src_Makefile.am 
  Log:
  - Mark MAKE_JOBS_UNSAFE
  
  PR:             ports/163465
  Submitted by:   "T.J." <baotserver@gmail.com>
  
  - Remove dependency on unzip
  
  Submitted by:   Takefu <takefu@airport.fm> (maintainer)
  
  Revision  Changes    Path
  1.11      +1 -3      ports/audio/libaacplus/Makefile
  1.2       +27 -3     ports/audio/libaacplus/files/patch-configure.ac
  1.1       +19 -0     ports/audio/libaacplus/files/patch-src_Makefile.am (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Chris Rees freebsd_committer freebsd_triage 2012-02-06 18:24:04 UTC
State Changed
From-To: feedback->closed

Committed.  Thanks for the unzip fix as well Takefu!