After the update to rxvt-unicode to version 9.14 the port fails to compile on 9.x. the following error is produced: c++ -I.. -I. -I. -I./../libev -I./../libptytty/src -I./../libecb -DHAVE_CONFIG_H -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include -O2 -pipe -march=nocona -fno-strict-aliasing -w -I/usr/local/include -D_REENTRANT -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/include/startup-notification-1.0 -c ptytty_wrapper.C In file included from ptytty_wrapper.C:11: ./../libptytty/src/logging.C: In function 'void fill_utmpx(utmpx*, bool, int, const char*, const char*, const char*)': ./../libptytty/src/logging.C:267: error: 'id' was not declared in this scope *** Error code 1 Stop in /usr/ports/x11/rxvt-unicode/work/rxvt-unicode-9.14/src. *** Error code 1 That part of code is protected by #ifdef HAVE_STRUCT_UTMPX, so the problem shows up only on 9.x and upper. Fix: The patch files/patch-libptytty-src-logging.C contained a fix needed with the previous version of the software. It is not needed anymore. In fact that patch adds a line referring to a variable which is not present in the code anymore. Removing files/patch-libptytty-src-logging.C compeltely now fixes the problem. The code of the software has been changed and does not need patching anymore. patch, just in case: How-To-Repeat: on a 9.x machine(with UTMPX): # cd /usr/ports/x11/rxvt-unicode && make
Responsible Changed From-To: freebsd-ports-bugs->thierry Over to maintainer (via the GNATS Auto Assign Tool)
thierry 2011-12-23 16:44:11 UTC FreeBSD ports repository Modified files: x11/rxvt-unicode/files patch-libptytty-src-logging.C Log: Fix build on 9.x. PR: ports/163561 Submitted by: Guido Falsi <mad (at) madpilot.net> Patch from: flo Revision Changes Path 1.4 +1 -1 ports/x11/rxvt-unicode/files/patch-libptytty-src-logging.C _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Thanks for the notification! Note: I kept the patch, just fixed it, so that we don't fail again in the case you reported in PR ports/161298.