I was unable to reproduce this fault.  Which options did you have set 
when you built it?

Getting rid of these kinds of errors is quite easy to do.  But it would 
be a kind of bandaid fix.

I notice that the source web site has version 1.8.4.  (Even the 
xorp-devel port is very out of date.)  What really needs to happen is 
that someone needs to take maintainership of this port, and update it.  
This needs to be done by someone with a vested interest in keeping this 
software alive.  If you are willing to take maintainership, email me or 
someone else who can give it to you.

Comment 2 Eitan Adler 2011-12-26 14:52:30 UTC

State Changed
From-To: open->feedback

per stephen

Comment 3 Stephen Montgomery-Smith 2011-12-26 16:25:30 UTC

Responsible Changed
From-To: freebsd-ports-bugs->stephen

So I will receive any feedback.

Hi Stephen.  Thank you for responding.

Here is my /var/db/ports/xorp/options:

# This file is auto-generated by 'make config'.
# No user-servicable parts inside!
# Options for xorp-1.5
_OPTIONS_READ=xorp-1.5
WITH_ADVMCAST=true
WITH_IPV6=true
WITH_SNMP=true
WITH_OPTIMIZATION=true
WITHOUT_CHECK=true
WITHOUT_DEBUGGING=true
WITHOUT_PROFILING=true

I am installing this port to evaluate it as a possible replacement for
net/quagga in an OSPF-only network.  I will be unable to reliably
perform RIP or BGP testing.  However, I'd be happy to take a stab at
bringing it up-to-date.  My current schedule would allow for me to do
that in about a week or two, and I would certainly be interested in
taking on the role of maintainer at that time.

-- 
Anthony Chavez                                  http://hexadecagram.org/
mailto:acc@hexadecagram.org                    xmpp:acc@hexadecagram.org

Can you try out the attached patch?

As well as small changes to Makefile, it should put in three new files:
files/patch_mibs_bgp4_mib_1657_bgp4pathattrtable.cc
files/patch_mibs_bgp4_mib_1657_bgppeertable.cc
files/patch_mibs_xorpevents.cc

P.S. I built it on an amd64 FreeBSD 8.2 computer, so I picked up an 
error in xorpevents.cc which your system didn't seem to pick up.

Regarding maintainership, do you mind if I set you as maintainer today 
or tomorrow?  It doesn't mean you have to start working on it right 
away.  Indeed getting to it in a few weeks would be very timely.  Also, 
if you find you don't have enough time you can always give it back to 
ports@ anytime you like.

Stephen

I've applied the patch, which created the following files:

patch-mibs-bgp4_mib_1657_bgp4pathattrtable.cc
patch-mibs-bgp4_mib_1657_bgppeertable.cc
patch-mibs-xorpevents.cc

I then attempted a build, which resulted in a different error, as follows:

 c++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
-DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"mibs\"
-DVERSION=\"1.6\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_LIBCRYPTO=1
-DHAVE_NET_SNMP_AGENT_NET_SNMP_AGENT_INCLUDES_H=1
-DHAVE_NET_SNMP_LIBRARY_CONTAINER_H=1 -I. -I./.. -I./..
-DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -O2 -pipe
-fno-strict-aliasing -Ufreebsd8 -Dfreebsd8=freebsd8
-DAPPLLIB_EXP=/usr/local/lib/perl5/5.14.2/BSDPAN -DHAS_FPSETMASK
-DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include -I/usr/local/lib/perl5/5.14.2/mach/CORE
-I/usr/local/include -I. -I/usr/local/include -DNETSNMP_NO_INLINE
-UPACKAGE -UPACKAGE_BUGREPORT -UPACKAGE_NAME -UPACKAGE_STRING
-UPACKAGE_TARNAME -UPACKAGE_VERSION -I/usr/local/include
-Wno-uninitialized -DNETSNMP_NO_INLINE -Werror -W -Wall -Wwrite-strings
-Wcast-qual -Wpointer-arith -Wcast-align -Woverloaded-virtual
-ftemplate-depth-25 -pipe -MT xorpevents.lo -MD -MP -MF
.deps/xorpevents.Tpo -c xorpevents.cc  -fPIC -DPIC -o .libs/xorpevents.o
cc1plus: warnings being treated as errors
xorpevents.cc: In function 'void run_timer_callbacks(u_int, void*)':
xorpevents.cc:58: warning: format '%jd' expects type 'intmax_t', but
argument 3 has type 'size_t'
xorpevents.cc:58: warning: format '%jd' expects type 'intmax_t', but
argument 3 has type 'size_t'
gmake[3]: *** [xorpevents.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/net/xorp/work/xorp-1.6/mibs'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/net/xorp/work/xorp-1.6/mibs'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/net/xorp/work/xorp-1.6'
gmake: *** [all] Error 2
*** Error code 1

Stop in /usr/ports/net/xorp.
*** Error code 1

Stop in /usr/ports/net/xorp.

It may be worth noting that I updated my ports tree after initially
submitting this PR, which made portmaster upgrade to perl-5.14.2 and
net-snmp-5.7.1_3 before net/xorp.

Whenever you want to set me as a maintainer would be fine.

-- 
Anthony Chavez                                  http://hexadecagram.org/
mailto:acc@hexadecagram.org                    xmpp:acc@hexadecagram.org

This patch should work.  I have tested in on thr amd64 and the i386.  
The only difference between this patch and the previous one is that I 
used %zd instead of %jd.

I have applied the latter patch (with %zd) and executed a clean build
successfully.  Thanks for the assistance.

-- 
Anthony Chavez                                  http://hexadecagram.org/
mailto:acc@hexadecagram.org                    xmpp:acc@hexadecagram.org

Comment 9 dfilter service 2011-12-28 16:40:16 UTC

stephen     2011-12-28 16:39:51 UTC

  FreeBSD ports repository

  Modified files:
    net/xorp             Makefile pkg-plist 
  Added files:
    net/xorp/files       
                         patch-mibs-bgp4_mib_1657_bgp4pathattrtable.cc 
                         patch-mibs-bgp4_mib_1657_bgppeertable.cc 
                         patch-mibs-xorpevents.cc 
  Log:
  - Add patches to allow build with SNMP on.
  - Change BUILD_DEPENDS= to BUILD_DEPENDS+= so that different options don't
    negate each other.
  - Set maintainer.
  
  PR:             ports/163584
  Submitted by:   Anthony Chavez <acc@hexadecagram.org>
  
  Revision  Changes    Path
  1.18      +3 -3      ports/net/xorp/Makefile
  1.1       +35 -0     ports/net/xorp/files/patch-mibs-bgp4_mib_1657_bgp4pathattrtable.cc (new)
  1.1       +11 -0     ports/net/xorp/files/patch-mibs-bgp4_mib_1657_bgppeertable.cc (new)
  1.1       +11 -0     ports/net/xorp/files/patch-mibs-xorpevents.cc (new)
  1.7       +0 -1      ports/net/xorp/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 10 Stephen Montgomery-Smith 2011-12-28 16:40:33 UTC

State Changed
From-To: feedback->closed

Fix committed.  Thanks!