Bug 163606 - [patch] lang/v8: make sure that CFLAGS always contains -fno-strict-aliasing
Summary: [patch] lang/v8: make sure that CFLAGS always contains -fno-strict-aliasing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-25 13:10 UTC by Panagiotis Christias
Modified: 2011-12-25 15:40 UTC (History)
0 users

See Also:

Attachments
file.diff (481 bytes, patch)
2011-12-25 13:10 UTC, Panagiotis Christias 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Panagiotis Christias 2011-12-25 13:10:11 UTC 
lang/v8 needs -fno-strict-aliasing to compile properly, so if CFLAGS is defined outside the port's Makefile (e.g. in /etc/make.conf) and does not contain -fno-strict-aliasing then default value of CFLAGS gets overwritten and building fails.

Merry Christmas,
Panagiotis

Fix: See attached patch (could be done in a better way i suppose).

Patch attached with submission follows:
How-To-Repeat: Have something like "CFLAGS=-O -pipe" and try to build lang/v8:

# echo "CFLAGS=-O -pipe" >> /etc/make.conf
# cd /usr/ports/lang/v8
# make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-25 13:10:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->vanilla

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-12-25 15:33:55 UTC 
vanilla     2011-12-25 15:33:41 UTC

  FreeBSD ports repository

  Modified files:
    lang/v8              Makefile distinfo 
    lang/v8/files        patch-SConstruct 
  Removed files:
    lang/v8/files        patch-platform-freebsd.cc 
  Log:
  1: Upgrade to 3.8.2.
  2: handle '-fno-strict-aliasing'.
  
  PR:             ports/163606
  Submitted by:   Panagiotis Christias <p.christias at noc.ntua.gr> [2]
  
  Revision  Changes    Path
  1.12      +9 -1      ports/lang/v8/Makefile
  1.9       +2 -2      ports/lang/v8/distinfo
  1.3       +3 -3      ports/lang/v8/files/patch-SConstruct
  1.2       +0 -136    ports/lang/v8/files/patch-platform-freebsd.cc (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Vanilla I. Shu freebsd_committer freebsd_triage 2011-12-25 15:34:08 UTC 
State Changed
From-To: open->closed

Committed, thanks.