I've forgotten to send in a file with my original submission of this port (sorry!) - this means that ports that depend on ocaml-react will not be able to find it. (this affects at least devel/ocaml-lwt). Fix: Save the attached file as files/patch-src_META of the port directory and the problem should be solved. Patch attached with submission follows: How-To-Repeat: Try to compile devel/ocaml-lwt (the version submitted in ports/163276); this should not work.
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
Sorry this took so long Had two issues. #1, if WITHOUT_X11 is defined in /etc/make.conf or make env, ocaml-react try to reinstall ocaml, even if it was installed with its -notk cousin: ===> ocaml-react-0.9.2_1 depends on package: ocaml>=3.11 - not found ===> Verifying install for ocaml>=3.11 in /usr/ports/lang/ocaml ===> License check disabled, port has not defined LICENSE ===> Found saved configuration for ocaml-notk-3.12.1 with slight patch to Makefile, this is fixed (is this ok?) ===> ocaml-react-0.9.2_1 depends on package: ocaml-notk>=3.11 - found /bin/mkdir -p /usr/local/lib/ocaml/site-lib ===> Patching for ocaml-react-0.9.2_1 ===> ocaml-react-0.9.2_1 depends on package: ocaml-notk>=3.11 - found ===> Applying FreeBSD patches for ocaml-react-0.9.2_1 Issue #2: if I do NOT patch pkg-plist, these files are left over after port: === Checking filesystem state after all packages deleted 351 ================================================================ 352 list of extra files and directories in / (not present on clean system but present after everything was deinstalled) 353 6150776 16 drwxr-xr-x 3 root wheel 7680 Jan 3 01:43 usr/local/lib/ocaml 354 6209671 4 drwxr-xr-x 2 root wheel 512 Jan 3 01:42 usr/local/lib/ocaml/site-lib if I ~DO~ patch it, build script shows me this warning: (which I think we can safely ignore: === Checking filesystem state 333 list of files present before this port was installed but missing after it was deinstalled) 334 ./usr/local/lib/ocaml/site-lib missing Jaap: are my patches ok? Gabor: if Jaap agrees, is it ok to commit? given this (warning)? === Checking filesystem state 333 list of files present before this port was installed but missing after it was deinstalled) 334 ./usr/local/lib/ocaml/site-lib missing These files WERE NOT PRESENT before the port installed; portinstall -pP lang/ocaml scanner.secnap.net# ls -l /usr/local/lib/ocaml/site-lib ls: /usr/local/lib/ocaml/site-lib: No such file or directory -- Michael Scheidell, CTO SECNAP Network Security Corporation (561) 999-5000 scheidell@secnap.net http://www.secnap.com/ ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.spammertrap.com/ ______________________________________________________________________
State Changed From-To: open->feedback Waiting on maintainers approval on modified patch
State Changed From-To: feedback->closed Committed with changes, Thanks
scheidell 2012-01-07 18:17:09 UTC FreeBSD ports repository Modified files: devel/ocaml-react Makefile pkg-plist Added files: devel/ocaml-react/files patch-src_META Log: - patch to make devel/ocaml-react work with ocamlfind [1] - Add check for X11 so ocaml-nox11 is used as dependency if WITHOUT_X11 is defined [2] PR: ports/163717 [1] Submitted by: jaapb@kerguelen.org (maintainer) [1] Reviewed by: scheidell [2] Approved by: jaapb@kerguelen.org (maintainer), gabor (mentor) Revision Changes Path 1.3 +6 -0 ports/devel/ocaml-react/Makefile 1.1 +7 -0 ports/devel/ocaml-react/files/patch-src_META (new) 1.3 +1 -0 ports/devel/ocaml-react/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"