Bug 163761 - deskutils/vboxgtk: fix install failure
Summary: deskutils/vboxgtk: fix install failure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexander Logvinov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-02 05:00 UTC by Barbara
Modified: 2013-01-27 11:12 UTC (History)
0 users

See Also:


Attachments
file.diff (627 bytes, patch)
2012-01-02 05:00 UTC, Barbara
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara 2012-01-02 05:00:27 UTC
I tried installing the last version of vboxgtk, but starting it I get the following error:

$ vboxgtk 

(vboxgtk:20081): Gtk-WARNING **: Unknown property: GtkAboutDialog.license-type
/usr/local/lib/python2.7/site-packages/gi/types.py:44: Warning: cannot create instance of abstract (non-instantiatable) type `GtkBox'
  return info.invoke(*args)


From what I can understand after reading about that error message, the problem is that it has been developed with a version of glade targeting gtk-3.
In fact, installing x11-toolkits/gtk30, the application starts normally.

With the attached patch the application starts even using gtk-2.
As it's the first time I see that application, I can't judge if something get broken by this and at the moment I have no time to do test it thoroughly against both gtk versions.

Fix: Either make the port depending on x11-toolkits/gtk30 or patch ${WRKSRC}/data/xml/vboxgtk.xml

Patch attached with submission follows:
How-To-Repeat: Install deskutils/vboxgtk and start vboxgtk without having x11-toolkits/gtk30 installed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-02 05:00:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->avl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Barbara 2012-01-02 05:13:33 UTC
Sorry, I forgot to complete the summary of the problem.

And also there is a wrong (void) substitution in the patch: the first one 
should replace GtkBox with GtkHBox and the following line could be deleted.
The correct patch could be found here:
http://pastebin.com/2d4y3G1e
Comment 3 Mark Linimon 2012-01-02 13:45:49 UTC
----- Forwarded message from Barbara <barbara.xxx1975@libero.it> -----

Date: Mon, 2 Jan 2012 06:22:58 +0100 (CET)
From: Barbara <barbara.xxx1975@libero.it>
To: freebsd-ports-bugs@freebsd.org
Subject: Re: ports/163761: deskutils/vboxgtk:

Sorry, I forgot to complete the summary of the problem.

And also there is a wrong (void) substitution in the patch: the first one
should replace GtkBox with GtkHBox and the following line could be deleted.
The correct patch can be found here:
http://pastebin.com/2d4y3G1e

----- End forwarded message -----
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-12 00:06:47 UTC
Responsible Changed
From-To: avl->pgollucci

committer&maintainer timeout (avl ; 41 days) / last commit: 12 days ago
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2012-06-22 03:20:27 UTC
Responsible Changed
From-To: pgollucci->freebsd-ports-bugs

With bugmeister hat, return to pool due to assignee ENOTIME. 

Note that this PR was already available for commit via maintainer-timeout.
Comment 6 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-16 07:59:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->avl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-01-27 11:09:09 UTC
Author: bar
Date: Sun Jan 27 11:08:55 2013
New Revision: 311054
URL: http://svnweb.freebsd.org/changeset/ports/311054

Log:
  - Update to version 0.8.2
  - Convert to OptionsNG
  - Trim Makefile headers
  
  PR:		ports/163761
  PR:		ports/175246
  Approved by:	flo (mentor), (maintainer timeout)

Modified:
  head/deskutils/vboxgtk/Makefile
  head/deskutils/vboxgtk/distinfo

Modified: head/deskutils/vboxgtk/Makefile
==============================================================================
--- head/deskutils/vboxgtk/Makefile	Sun Jan 27 10:05:18 2013	(r311053)
+++ head/deskutils/vboxgtk/Makefile	Sun Jan 27 11:08:55 2013	(r311054)
@@ -1,27 +1,26 @@
-# New ports collection makefile for:	vboxgtk
-# Date created:				13 June 2009
-# Whom:					Alexander Logvinov <avl@FreeBSD.org>
-#
+# Created by: Alexander Logvinov <avl@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	vboxgtk
-PORTVERSION=	0.7.0
-PORTREVISION=	2
+PORTVERSION=	0.8.2
 CATEGORIES=	deskutils emulators gnome
-MASTER_SITES=	SF
+MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE}
 
 MAINTAINER=	avl@FreeBSD.org
 COMMENT=	GTK frontend for VirtualBox
 
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/xpcom/vboxxpcom.py:${PORTSDIR}/emulators/virtualbox-ose-legacy
+RUN_DEPENDS=	${PYTHON_SITELIBDIR}/xpcom/vboxxpcom.py:${PORTSDIR}/emulators/virtualbox-ose
 
 USE_PYTHON=	yes
-USE_GNOME=	pygtk2
+USE_GNOME=	gtk30 pygtk2
 USE_PYDISTUTILS=	yes
 INSTALLS_ICONS=	yes
 
-.if !defined(WITHOUT_NLS)
+OPTIONS_DEFINE=	NLS
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=	yes
 PLIST_SUB+=	NLS=""
 .else
@@ -29,7 +28,7 @@ PLIST_SUB+=	NLS="@comment "
 .endif
 
 post-patch:
-.if defined(WITHOUT_NLS)
+.if ! ${PORT_OPTIONS:MNLS}
 	@${REINPLACE_CMD} -e '/self.add_mo_files/d' \
 		-e '/os.system("intltool/d' ${WRKSRC}/setup.py
 .endif

Modified: head/deskutils/vboxgtk/distinfo
==============================================================================
--- head/deskutils/vboxgtk/distinfo	Sun Jan 27 10:05:18 2013	(r311053)
+++ head/deskutils/vboxgtk/distinfo	Sun Jan 27 11:08:55 2013	(r311054)
@@ -1,2 +1,2 @@
-SHA256 (vboxgtk-0.7.0.tar.gz) = 19294561ae9f67a3e7a22a35158f88fc7ae0f4c652f64d6076401a902c3afd59
-SIZE (vboxgtk-0.7.0.tar.gz) = 41867
+SHA256 (vboxgtk-0.8.2.tar.gz) = 317d7b55cc0c98bf3c1fe294a8fc62668709ae14f12b3bf3b32d5fa33451fe95
+SIZE (vboxgtk-0.8.2.tar.gz) = 43717
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 8 Barbara Guida freebsd_committer freebsd_triage 2013-01-27 11:12:44 UTC
State Changed
From-To: open->closed

Superseded by ports/175246