Bug 164101 - x11/xterm: update to xterm-277 broke meta-keys
Summary: x11/xterm: update to xterm-277 broke meta-keys
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 22:20 UTC by Garrett Wollman
Modified: 2012-01-20 00:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Wollman 2012-01-13 22:20:07 UTC
meta-keys worked properly (set eighth bit of the character typed) in
xterm-276.  They don't work in xterm-277 (character is sent
unmodified).  Tried both settings of altIsNotMeta (no change).  Tried
explicitly setting eightBitMeta (no change).

Fix: 

unknown
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-01-15 00:32:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Fix synopsis and assign.
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2012-01-18 10:00:38 UTC
State Changed
From-To: open->analyzed

Solutions being sought with the upstream project.
Comment 3 Thomas E. Dickey 2012-01-18 10:49:41 UTC
On Tue, Jan 17, 2012 at 05:16:18PM -0500, Thomas Dickey wrote:
> On Tue, Jan 17, 2012 at 06:27:42PM +0100, Emanuel Haupt wrote:
> > Christian Weisgerber <naddy@FreeBSD.org> wrote:
> > > Hi,
> > > I have these resource settings:
> > > 
> > > XTerm*backarrowKeyIsErase: true
> > > XTerm*ptyInitialErase:  true
> > > 
> > > On FreeBSD, this gives me a stty erase setting of ^? in a new xterm
> > > and correspondingly backarrowKey is false (produces delete).
> > > 
> > > However, after updating xterm from 276 to 277, backarrowKey is now
> > > set to true (produces backspace).  I just went back to 276 and
> > > verified that it is indeed the xterm update that causes the behavior
> > > change.  A bug?
> > 
> > Most probably. This seems to be related with the following bug report:
> > 
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164101
> > (submitter CC'ed)
> 
> possibly - for whatever reason, the problem is not appearing in my
> regular test-environment, so I've started setting up a FreeBSD 8.2 with
> X running on it (I've been testing on my FreeBSD VMs via Mac OS X,
> which gets in the way of the meta stuff).  Reviewing my changes, I
> have a few things to investigate as possibilities:
> 
> a) I added some data to the "Misc" structure, which has been the source
>    of problems with FreeBSD since it's always zeroed on Linux but not
>    elsewhere.
> b) I did some restructuring of the XIM-related code (which happens to
>    be used by the X keyboard stuff), while looking for a solution to
>    a report that compose doesn't work in the scrollbar area.
> c) I modified things to prefer posix_openpt if it's available.
> 
> The last is the only simple one to suggest undoing - turns out that
> "older" Mac OS X doesn't handle that function call, so I have a tweak
> to suppress it for the 9.x kernels (see ftp://invisible-island.net/temp). 


I can reproduce this with a new install of 8.2 and the xterm 277 port
(comparing with #267).

Will investigate, etc.

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2012-01-18 12:48:25 UTC
Thomas Dickey <dickey@his.com> wrote:
> On Tue, Jan 17, 2012 at 05:16:18PM -0500, Thomas Dickey wrote:
> > On Tue, Jan 17, 2012 at 06:27:42PM +0100, Emanuel Haupt wrote:
> > > Christian Weisgerber <naddy@FreeBSD.org> wrote:
> > > > Hi,
> > > > I have these resource settings:
> > > > 
> > > > XTerm*backarrowKeyIsErase: true
> > > > XTerm*ptyInitialErase:  true
> > > > 
> > > > On FreeBSD, this gives me a stty erase setting of ^? in a new
> > > > xterm and correspondingly backarrowKey is false (produces
> > > > delete).
> > > > 
> > > > However, after updating xterm from 276 to 277, backarrowKey is
> > > > now set to true (produces backspace).  I just went back to 276
> > > > and verified that it is indeed the xterm update that causes the
> > > > behavior change.  A bug?
> > > 
> > > Most probably. This seems to be related with the following bug
> > > report:
> > > 
> > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164101
> > > (submitter CC'ed)
> > 
> > possibly - for whatever reason, the problem is not appearing in my
> > regular test-environment, so I've started setting up a FreeBSD 8.2
> > with X running on it (I've been testing on my FreeBSD VMs via Mac
> > OS X, which gets in the way of the meta stuff).  Reviewing my
> > changes, I have a few things to investigate as possibilities:
> > 
> > a) I added some data to the "Misc" structure, which has been the
> > source of problems with FreeBSD since it's always zeroed on Linux
> > but not elsewhere.
> > b) I did some restructuring of the XIM-related code (which happens
> > to be used by the X keyboard stuff), while looking for a solution to
> >    a report that compose doesn't work in the scrollbar area.
> > c) I modified things to prefer posix_openpt if it's available.
> > 
> > The last is the only simple one to suggest undoing - turns out that
> > "older" Mac OS X doesn't handle that function call, so I have a
> > tweak to suppress it for the 9.x kernels (see
> > ftp://invisible-island.net/temp). 
> 
> I can reproduce this with a new install of 8.2 and the xterm 277 port
> (comparing with #267).
> 
> Will investigate, etc.

Thank you very much for looking into this. Please let me know if there
is anything I can help you with. I could provide you a virtualbox image
if needed.

Emanuel
Comment 5 Thomas E. Dickey 2012-01-18 21:46:52 UTC
On Wed, Jan 18, 2012 at 01:48:25PM +0100, Emanuel Haupt wrote:
> Thomas Dickey <dickey@his.com> wrote:
> > On Tue, Jan 17, 2012 at 05:16:18PM -0500, Thomas Dickey wrote:
> > > On Tue, Jan 17, 2012 at 06:27:42PM +0100, Emanuel Haupt wrote:
> > > > Christian Weisgerber <naddy@FreeBSD.org> wrote:
> > > > > Hi,
> > > > > I have these resource settings:
> > > > > 
> > > > > XTerm*backarrowKeyIsErase: true
> > > > > XTerm*ptyInitialErase:  true
> > > > > 
> > > > > On FreeBSD, this gives me a stty erase setting of ^? in a new
> > > > > xterm and correspondingly backarrowKey is false (produces
> > > > > delete).
> > > > > 
> > > > > However, after updating xterm from 276 to 277, backarrowKey is
> > > > > now set to true (produces backspace).  I just went back to 276
> > > > > and verified that it is indeed the xterm update that causes the
> > > > > behavior change.  A bug?
> > > > 
> > > > Most probably. This seems to be related with the following bug
> > > > report:
> > > > 
> > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164101
> > > > (submitter CC'ed)
> > > 
> > > possibly - for whatever reason, the problem is not appearing in my
> > > regular test-environment, so I've started setting up a FreeBSD 8.2
> > > with X running on it (I've been testing on my FreeBSD VMs via Mac
> > > OS X, which gets in the way of the meta stuff).  Reviewing my
> > > changes, I have a few things to investigate as possibilities:
> > > 
> > > a) I added some data to the "Misc" structure, which has been the
> > > source of problems with FreeBSD since it's always zeroed on Linux
> > > but not elsewhere.
> > > b) I did some restructuring of the XIM-related code (which happens
> > > to be used by the X keyboard stuff), while looking for a solution to
> > >    a report that compose doesn't work in the scrollbar area.
> > > c) I modified things to prefer posix_openpt if it's available.
> > > 
> > > The last is the only simple one to suggest undoing - turns out that
> > > "older" Mac OS X doesn't handle that function call, so I have a
> > > tweak to suppress it for the 9.x kernels (see
> > > ftp://invisible-island.net/temp). 
> > 
> > I can reproduce this with a new install of 8.2 and the xterm 277 port
> > (comparing with #267).
> > 
> > Will investigate, etc.
> 
> Thank you very much for looking into this. Please let me know if there
> is anything I can help you with. I could provide you a virtualbox image
> if needed.


at the moment I think I have enough information, since I was able
to repeat it in my 8.2 machine.  I'll probably narrow it down this
evening, and see what I have to fix (thanks).

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
Comment 6 Thomas E. Dickey 2012-01-19 00:06:25 UTC
On Wed, Jan 18, 2012 at 04:46:52PM -0500, Thomas Dickey wrote:
> at the moment I think I have enough information, since I was able
> to repeat it in my 8.2 machine.  I'll probably narrow it down this
> evening, and see what I have to fix (thanks).


I found the error (an incorrect variable in initializing the eightBitMeta
resource - will fix/etc).


-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
Comment 7 Thomas E. Dickey 2012-01-19 02:13:28 UTC
On Wed, Jan 18, 2012 at 07:06:25PM -0500, Thomas Dickey wrote:
> On Wed, Jan 18, 2012 at 04:46:52PM -0500, Thomas Dickey wrote:
> > at the moment I think I have enough information, since I was able
> > to repeat it in my 8.2 machine.  I'll probably narrow it down this
> > evening, and see what I have to fix (thanks).
> 
> I found the error (an incorrect variable in initializing the eightBitMeta
> resource - will fix/etc).


                            Patch #278 - 2012/01/18

     * correct initialization for eightBitMeta resource (FreeBSD #164101).
     * make special check for Darwin 9 (and lower) to not use posix_openpt
       (report by Christian Ebert).
     * minor  fixes  (adding  ".ne"  directives) to reduce the cases where
       groff's  utility  for generating images for tables dumps core. Most
       versions  of  groff  (I've found 1.19.2 to be the most stable) dump
       core  when  attempting  to report that there are too few lines on a
       page for a table to be shown.


-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
Comment 8 dfilter service freebsd_committer freebsd_triage 2012-01-19 15:53:21 UTC
ehaupt      2012-01-19 15:53:11 UTC

  FreeBSD ports repository

  Modified files:
    x11/xterm            Makefile distinfo 
  Log:
  Update to 278. This solves a problem with the initialization for eightBitMeta
  resource. Special thanks to the author [1] who fixed this upstream so promptly.
  
  PR:             164101 [2] (notification)
  Submitted by:   Thomas Dickey <dickey@his.com> [1]
  Notified by:    Garrett Wollman [2] <wollman@khavrinen.csail.mit.edu>,
                  naddy (via mail)
  
  Revision  Changes    Path
  1.94      +1 -1      ports/x11/xterm/Makefile
  1.58      +2 -2      ports/x11/xterm/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Emanuel Haupt freebsd_committer freebsd_triage 2012-01-19 15:53:35 UTC
Thomas Dickey <dickey@his.com> wrote:
> On Wed, Jan 18, 2012 at 07:06:25PM -0500, Thomas Dickey wrote:
> > On Wed, Jan 18, 2012 at 04:46:52PM -0500, Thomas Dickey wrote:
> > > at the moment I think I have enough information, since I was able
> > > to repeat it in my 8.2 machine.  I'll probably narrow it down this
> > > evening, and see what I have to fix (thanks).
> > 
> > I found the error (an incorrect variable in initializing the
> > eightBitMeta resource - will fix/etc).
> 
>                             Patch #278 - 2012/01/18
> 
>      * correct initialization for eightBitMeta resource (FreeBSD
> #164101).
>      * make special check for Darwin 9 (and lower) to not use
> posix_openpt (report by Christian Ebert).
>      * minor  fixes  (adding  ".ne"  directives) to reduce the cases
> where groff's  utility  for generating images for tables dumps core.
> Most versions  of  groff  (I've found 1.19.2 to be the most stable)
> dump core  when  attempting  to report that there are too few lines
> on a page for a table to be shown.

I have just updated the FreeBSD port to 278. Thank you very much for
fixing this so promptly!

Emanuel
Comment 10 Emanuel Haupt freebsd_committer freebsd_triage 2012-01-19 15:55:41 UTC
State Changed
From-To: analyzed->closed

Port updated to 278.
Comment 11 Thomas E. Dickey 2012-01-19 22:22:26 UTC
On Thu, Jan 19, 2012 at 04:53:35PM +0100, Emanuel Haupt wrote:
> Thomas Dickey <dickey@his.com> wrote:
> > On Wed, Jan 18, 2012 at 07:06:25PM -0500, Thomas Dickey wrote:
> > > On Wed, Jan 18, 2012 at 04:46:52PM -0500, Thomas Dickey wrote:
> > > > at the moment I think I have enough information, since I was able
> > > > to repeat it in my 8.2 machine.  I'll probably narrow it down this
> > > > evening, and see what I have to fix (thanks).
> > > 
> > > I found the error (an incorrect variable in initializing the
> > > eightBitMeta resource - will fix/etc).
> > 
> >                             Patch #278 - 2012/01/18
> > 
> >      * correct initialization for eightBitMeta resource (FreeBSD
> > #164101).
> >      * make special check for Darwin 9 (and lower) to not use
> > posix_openpt (report by Christian Ebert).
> >      * minor  fixes  (adding  ".ne"  directives) to reduce the cases
> > where groff's  utility  for generating images for tables dumps core.
> > Most versions  of  groff  (I've found 1.19.2 to be the most stable)
> > dump core  when  attempting  to report that there are too few lines
> > on a page for a table to be shown.
> 
> I have just updated the FreeBSD port to 278. Thank you very much for
> fixing this so promptly!


no problem (report bugs).

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
Comment 12 wollman 2012-01-19 23:37:25 UTC
<<On Thu, 19 Jan 2012 17:22:26 -0500, Thomas Dickey <dickey@his.com> said:

> no problem (report bugs).

I can confirm that it works for me.

-GAWollman