Bug 164140 - [maintainer] Updating games/stockfish to 2.2.1
Summary: [maintainer] Updating games/stockfish to 2.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-15 15:10 UTC by Gautam Mani
Modified: 2012-01-18 20:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.36 KB, patch)
2012-01-15 15:10 UTC, Gautam Mani
no flags Details | Diff
patch.txt (2.85 KB, text/plain; charset=us-ascii)
2012-01-15 20:40 UTC, Jason Helfman
no flags Details
patch.txt (2.58 KB, text/plain; charset=us-ascii)
2012-01-15 20:55 UTC, Jason Helfman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gautam Mani 2012-01-15 15:10:10 UTC
Here is the port updated to stockfish 2.2.1. Patch is attached.
Changed upstream master-site to the official archive available in dropbox due to continuous 
changes and having dynamic URLs.

How-To-Repeat: 	NA
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2012-01-15 19:07:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2012-01-15 20:40:39 UTC
Hi,

Would you please consider this patch? It drops pkg-plist, and conditionally
installs non-man and non-info documentation.

Thanks!
-jgh

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2012-01-15 20:55:18 UTC
Please ignore previous patch. This should do it. No need to PLIST_SUB
when plist was dropped.

-jgh

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 4 Gautam Mani 2012-01-17 17:36:03 UTC
On Sun, Jan 15, 2012 at 12:55:18PM -0800, Jason Helfman wrote:
> Please ignore previous patch. This should do it. No need to PLIST_SUB
> when plist was dropped.
> 

Thanks, couldnt access a system to test it, hence the delay. 
This is good, thanks! 

BTW, Are PORTDOCS and PORTDATA new additions to the port infrastructure? 

Cheers,
Gautam
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2012-01-17 18:08:23 UTC
On Tue, Jan 17, 2012 at 11:06:03PM +0530, Gautam Mani thus spake:
>On Sun, Jan 15, 2012 at 12:55:18PM -0800, Jason Helfman wrote:
>> Please ignore previous patch. This should do it. No need to PLIST_SUB
>> when plist was dropped.
>>
>
>Thanks, couldnt access a system to test it, hence the delay.
>This is good, thanks!
>
>BTW, Are PORTDOCS and PORTDATA new additions to the port infrastructure?
>
>Cheers,
>Gautam
>
>

No, they have been around for awhile.
There was a concern though regarding if PORTDATA is not enabled, but PORTDOCS
are enabled. In this case, the ini file will be installed, but the book file
will not. The ini file refers to the book file.

Is this an issue? Is the book file, required?

Thanks,
Jason

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 6 Gautam Mani 2012-01-18 05:04:55 UTC
Hi Jason,

On Tue, Jan 17, 2012 at 11:38 PM, Jason Helfman <jgh@freebsd.org> wrote:

>
> There was a concern though regarding if PORTDATA is not enabled, but
> PORTDOCS
> are enabled. In this case, the ini file will be installed, but the book
> file
> will not. The ini file refers to the book file.
>
> Is this an issue? Is the book file, required?
>
>
Both are not mandatory.

The ini file is used for integrating the chess engine with a GUI like
xboard -- and uses polyglot which needs to be separately setup since it is
not a port (yet)! It is not required for use with a UCI GUI for e.g.,
py-pychess.

The book file is used so that the chess engine can use it for choosing
standard opening chess moves from the opening book instead of "thinking"
them -- if not available the engine will calculate each move.

Thanks
Gautam
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-01-18 19:57:03 UTC
jgh         2012-01-18 19:56:54 UTC

  FreeBSD ports repository

  Modified files:
    games/stockfish      Makefile distinfo 
  Removed files:
    games/stockfish      pkg-plist 
  Log:
  - Update to 2.2.1
  - Changed upstream master-site to the official archive available in dropbox due to continuous
  changes and having dynamic URLs.
  - Respect PORTDOCS and PORTDATA
  - Migrate PLIST into Makefile
  
  PR:     ports/164140
  Submitted by: maintainer, Gautam Mani <gautam at execve.net>
  Approved by:    rene (mentor)
  
  Revision  Changes    Path
  1.4       +17 -6     ports/games/stockfish/Makefile
  1.3       +2 -2      ports/games/stockfish/distinfo
  1.4       +0 -6      ports/games/stockfish/pkg-plist (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Jason Helfman freebsd_committer freebsd_triage 2012-01-18 19:57:22 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!