Bug 164237 - [PATCH] security/suricata: overwrite files from libhtp
Summary: [PATCH] security/suricata: overwrite files from libhtp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 12:00 UTC by geoffroy desvernay
Modified: 2012-03-13 12:10 UTC (History)
1 user (show)

See Also:


Attachments
suricata-1.1.1_1.patch (2.36 KB, patch)
2012-01-17 12:00 UTC, geoffroy desvernay
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description geoffroy desvernay 2012-01-17 12:00:22 UTC
- suricata's port depends on devel/libhtp but does install another libhtp
- depens on net/libpcap but there is a libpcap in base system
- missing new config file reference.config
- override suricata.yaml

Proposed changes:
- depend on base system's libpcap by default, add an option to use port's one
- never install bundled libhtp (./configure --enable-non-bundled-htp)
- remove suricata.yaml and classification.config from plist (-> don't remove it on deinstall)
- add reference.config in CONFIG_FILES and reference.config-sample in plist (missing)

Port maintainer (eksffa@freebsdbrasil.com.br) is cc'd.

Generated with FreeBSD Port Tools 0.99

Fix: Attached patch seems to fix all of there bugs, but doesn't repair already installed/overwritten libhtp nor will keep ancien configs: perhaps a note in UPGRADING to inform to:
 1) copy configs
 2) uninstall suricata and libhtp (and libpcap if not needed elsewhere)
 3) reinstall suricata then config files

Or increase PORTREVISION of libhtp ? (maintainer cc'd)
How-To-Repeat: install security/suricata and see that:
- devel/libhtp's files are ovewritten in $PREFIX/(lib|include)
- net/libpcap is installed

Edit suricata.yaml, and/or classification.config

Upgrade suricata (reinstall it) and notice that your changes are lost :(
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-17 12:00:33 UTC
Maintainer of security/suricata,

Please note that PR ports/164237 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164237

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-17 12:00:37 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2012-01-17 14:01:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 4 Ryan Steinmetz freebsd_committer freebsd_triage 2012-02-23 15:25:07 UTC
Responsible Changed
From-To: wxs->zi

Taking as I am now the maintainer.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-03-13 12:04:35 UTC
zi          2012-03-13 12:04:26 UTC

  FreeBSD ports repository

  Modified files:
    security/suricata    Makefile pkg-descr pkg-plist 
    security/suricata/files pkg-message.in 
  Log:
  - Do not overwrite files from devel/libhtp [1]
  - Do not overwrite customized config files [1]
  - Optionally depend on libpcap from ports (off by default) [1]
  - Detect and use gcc hardening options by default
  - Cleanup language/whitespace
  - Bump PORTREVISION
  
  PR:             ports/164237 [1]
  Submitted by:   Geoffroy Desvernay <dgeo@centrale-marseille.fr> [1]
  Feature safe:   yes
  
  Revision  Changes    Path
  1.12      +25 -5     ports/security/suricata/Makefile
  1.2       +2 -2      ports/security/suricata/files/pkg-message.in
  1.3       +1 -8      ports/security/suricata/pkg-descr
  1.3       +10 -4     ports/security/suricata/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Ryan Steinmetz freebsd_committer freebsd_triage 2012-03-13 12:04:46 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!