Bug 164347 - comms/lrzsz fails to send ymodem
Summary: comms/lrzsz fails to send ymodem
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-21 02:10 UTC by maya
Modified: 2012-01-31 05:12 UTC (History)
0 users

See Also:

Attachments
file.diff (288 bytes, patch)
2012-01-21 02:10 UTC, maya 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description maya 2012-01-21 02:10:09 UTC 
YMODEM sends block0 to notify END OF TRANSFER.
But block0 includes invalid non-NULL data.
Because
struct stat f;
doesn't initialize f.st_size. The file size is exist, it is recognized as valid file transfer block.

Fix: Initialize f.st_size.

Patch attached with submission follows:
How-To-Repeat: lsz --ymodem foo.txt
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-21 02:10:19 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-01-31 04:41:44 UTC 
dinoex      2012-01-31 04:41:33 UTC

  FreeBSD ports repository

  Modified files:
    comms/lrzsz          Makefile 
  Added files:
    comms/lrzsz/files    patch-lsz.c 
  Log:
  - fix bug in ymodem with non zero malloc
  PR:             164347
  Submitted by:   NAGATA Shinya
  
  Revision  Changes    Path
  1.30      +1 -1      ports/comms/lrzsz/Makefile
  1.1       +10 -0     ports/comms/lrzsz/files/patch-lsz.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2012-01-31 05:11:50 UTC 
State Changed
From-To: open->closed

committed, thanks.