make -j with -j > 1 doesn't work out of the box today because of inherent race conditions in terms of how the licensing framework works today. Instead of properly defining the WRKDIR target in bsd.ports.mk, it was being defined inline in the package-noinstall target and implicitly being depended upon in the ${_LICENSE_COOKIE} target under bsd.licenses.mk . Fix: Patch attached with submission follows: How-To-Repeat: cd /usr/ports/devel/gettext; make -j10 all
Responsible Changed From-To: freebsd-ports-bugs->portmgr portmgr territory.
This patch goes a little bit further to break down some race conditions, but it's not perfect (the existing infrastructure gets hung up on other bits with ${TMPPLIST}), but it's a step forward. Thanks, -Garrett
Responsible Changed From-To: portmgr->miwi take for exprun
State Changed From-To: open->feedback Hi, This patchset reject for me .. can u please make an cvs diff .. 16:13][miwi@miwifbsd] $ patch -p1 --check < query-pr.cgi?pr=ports%2F164351&getpatch=2 (~/dev/ports/Mk) Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/bsd.licenses.mk b/bsd.licenses.mk |index 0247df7..348d4da 100644 |--- a/bsd.licenses.mk |+++ b/bsd.licenses.mk -------------------------- Patching file bsd.licenses.mk using Plan A... Hunk #1 failed at 574. Hunk #2 failed at 739. 2 out of 2 hunks failed--saving rejects to bsd.licenses.mk.rej Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/bsd.port.mk b/bsd.port.mk |index 1a29521..1bb9a6f 100644 |--- a/bsd.port.mk |+++ b/bsd.port.mk -------------------------- Patching file bsd.port.mk using Plan A... Hunk #1 failed at 1143. Hunk #2 failed at 1551. Hunk #3 failed at 3424. Hunk #4 failed at 3550. Hunk #5 failed at 3956. Hunk #6 failed at 4002. Hunk #7 failed at 4207. Hunk #8 failed at 4590. Hunk #9 failed at 4662. Hunk #10 failed at 4943. Hunk #11 failed at 5609. 11 out of 11 hunks failed--saving rejects to bsd.port.mk.rej
Responsible Changed From-To: miwi->portmgr back to portmgr, waiting of a new patch
A commit references this bug: Author: bapt Date: Tue Jul 15 13:13:04 UTC 2014 New revision: 361917 URL: http://svnweb.freebsd.org/changeset/ports/361917 Log: Fix simple condition in making directories Phabric: D101 PR: 164351 Submitted by: yaneurabeya@gmail.com Reviewed by: swills Changes: head/Mk/bsd.port.mk