Mhonarc version 2.6.18 when run with perl 10.14.2 complains about deprecated use of defined(%a_hash) statements. I've replaced these statements in the code where they occur and have generated the attached patch file(s). Since there is no maintainer for this port and that I have been using it for a number of years and will likely continue to do so, I am offering to become the maintainer. I've changed as much in the Makefile. Fix: See attached patch file(s) Patch attached with submission follows: How-To-Repeat: Run mhonarc with perl 10.14.2.
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->feedback Rickie: Thank you for your support of FreeBSD and the ports collection. We do appreciate your offer to step up and become a ports maintainer. If you have not yet, please make sure you read the port maintainers handbook: <http://www.freebsd.org/doc/en/books/porters-handbook/> Keep in mind that you can always ask questions on the ports@FreeBSD mailing list. One thing I would like you to fix in this PR is the patch files. It is trivial to do, but as a new maintainer, you need to make sure you pr's are 'patch ready' (ie: one of the committers will dl your patch and type: patch -Eui /tmp/patch.txt) This one won't patch until you move those *.pl patches to the files/ directory. See: <http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html> One more hint: (because this creates new files that diff won't pick up) in the files dir, 'touch' an empty patch-*.orig file for each new file Once you have a full working patch, feel free to do a submit followup on the pr and I will look at it. Any questions on the above, feel free to ask on ports@
I've changed the patch file so that it patches the files within the port directory for www/mhonarc. However, patch did not create the missing files directory and I've not found a way to deal with that other than creating www/mhonarc/files before appling the patch.
scheidell 2012-01-29 06:34:59 UTC FreeBSD ports repository Modified files: www/mhonarc Makefile Added files: www/mhonarc/files patch-lib__mhamain.pl patch-lib__mhopt.pl patch-lib__readmail.pl Log: - patching *.pl files to remove deprecated use of defined(%a_hash) statements - committer is now maintainer PR: ports/164560 Submitted by: Rickie Kerndt <kerndtr@kerndt.com> (maintainer) Approved by: maintainer, gabor (mentor, implicit) Revision Changes Path 1.46 +2 -1 ports/www/mhonarc/Makefile 1.1 +11 -0 ports/www/mhonarc/files/patch-lib__mhamain.pl (new) 1.1 +11 -0 ports/www/mhonarc/files/patch-lib__mhopt.pl (new) 1.1 +74 -0 ports/www/mhonarc/files/patch-lib__readmail.pl (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Please pass patches upstream to mhonarch.org. Watch for updates from mhonarch and remove patches when they fix this upstream. Thanks for your submittion. Committed.