Bug 164625 - [PATCH] port net-mgmt/icinga to support IDOUtils
Summary: [PATCH] port net-mgmt/icinga to support IDOUtils
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 10:00 UTC by Gianpaolo Del Matto
Modified: 2012-05-23 21:20 UTC (History)
0 users

See Also:


Attachments
file.diff (2.09 KB, patch)
2012-01-30 10:00 UTC, Gianpaolo Del Matto
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gianpaolo Del Matto 2012-01-30 10:00:20 UTC
Attached patch will add a new config option to the net-mgmt/icinga port, which adds this optional build arguments if selected:

WITH_MYSQL=client
LIB_DEPENDS+=           dbi.1:${PORTSDIR}/databases/libdbi-drivers
CONFIGURE_ARGS+=        --enable-idoutils
INSTALL_TARGET+=        install-idoutils
USE_RC_SUBR+=           ido2db

This will build icinga with support for IDOUtils.
It will also add an additional rc-script for ido2db to local base /etc/rc.d.

Actually, libdbi-drivers already has WITH_MYSQL as selectable dependency.
I added however WITH_MYSQL to the Icinga port as well, because building
libdbi-drivers with MYSQL deselected would make no sense.

As to my knowledge, Icinga would also support libdbi-drivers with PostgreSQL, but I didn't test that.

So the real dependency is:

Icinga -> libdbi-drivers -> with at least mysql or postgres (or both) enabled

While Icinga should make sure that either MySQL or PostgreSQL are available.

I'll be willing to implement this dependency correctly if my current approach would be wrong.

Fix: see patch file attached, applies cleanly to current port snapshot (jan/30/2012)

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-30 10:00:37 UTC
Responsible Changed
From-To: freebsd-ports-bugs->chinsan

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 chinsan freebsd_committer freebsd_triage 2012-01-31 07:14:49 UTC
Responsible Changed
From-To: chinsan->lme

Pass to new maintainer. Thanks for report.
Comment 3 Lars Engels 2012-02-23 19:52:38 UTC
Thank you for your PR. I took a look at it and I am working on a
slightly improved version of it together with a bigger re-write of the
port. I'll be afk the next week so please be patient.

Lars
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-05-23 21:13:35 UTC
lme         2012-05-23 20:13:22 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/icinga      Makefile distinfo pkg-plist 
    net-mgmt/icinga/files icinga.in patch-Makefile.in 
                          patch-base-Makefile.in 
                          patch-cgi-Makefile.in patch-configure.in 
                          patch-contrib-Makefile.in 
                          patch-include-locations.h.in 
                          pkg-message.in 
  Added files:
    net-mgmt/icinga/files ido2db.in 
                          patch-module-idoutils-src-Makefile.in 
  Log:
  - Update to 1.7.0 [1]
  - Add support for database backends using IDOutils [2]
  - Add a rc script for ido2db
  - Enable embedded Perl by default
  - Enable Event Broker by default
  - Enable statuswrl
  - Drop unnecessary use of USE_PHP
  - Install sample event handlers
  - Optionally depend on MySQL or PostgreSQL
  - Optionally depend on Apache and install the apropriate configuration for Icinga
  - Update pkg-message
  
  PR:             ports/167988 [1], ports/164625 [2]
  Submitted by:   gjb[1], Gianpaolo Del Matto <delmatto@phunsites.net> [2]
  
  Revision  Changes    Path
  1.9       +42 -12    ports/net-mgmt/icinga/Makefile
  1.5       +2 -2      ports/net-mgmt/icinga/distinfo
  1.3       +21 -13    ports/net-mgmt/icinga/files/icinga.in
  1.1       +31 -0     ports/net-mgmt/icinga/files/ido2db.in (new)
  1.3       +46 -12    ports/net-mgmt/icinga/files/patch-Makefile.in
  1.2       +7 -9      ports/net-mgmt/icinga/files/patch-base-Makefile.in
  1.3       +3 -3      ports/net-mgmt/icinga/files/patch-cgi-Makefile.in
  1.3       +19 -10    ports/net-mgmt/icinga/files/patch-configure.in
  1.3       +3 -3      ports/net-mgmt/icinga/files/patch-contrib-Makefile.in
  1.2       +9 -9      ports/net-mgmt/icinga/files/patch-include-locations.h.in
  1.1       +13 -0     ports/net-mgmt/icinga/files/patch-module-idoutils-src-Makefile.in (new)
  1.2       +9 -19     ports/net-mgmt/icinga/files/pkg-message.in
  1.4       +146 -20   ports/net-mgmt/icinga/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Lars Engels freebsd_committer freebsd_triage 2012-05-23 21:17:28 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!