Bug 164740 - www/trafficserver: configuration lost on upgrade
Summary: www/trafficserver: configuration lost on upgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 15:50 UTC by Radim Kolar
Modified: 2012-02-20 23:50 UTC (History)
0 users

See Also:


Attachments
patch.txt (8.95 KB, text/plain; charset=us-ascii)
2012-02-19 02:36 UTC, Jason Helfman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Radim Kolar 2012-02-03 15:50:08 UTC
because trafficserver configuration files are listed in package filelist,
package system deletes them on upgrade. User will losE his tuned configuration

How-To-Repeat: portupgrade -f trafficserver
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-15 03:53:48 UTC
Maintainer of www/trafficserver,

Please note that PR ports/164740 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164740

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-15 03:53:50 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2012-02-15 05:13:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

take, and what configuration files need to be preserved?
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2012-02-19 02:36:13 UTC
Here is a patch that should hopefully take care of this for you.

Over to portmgr to address if issue is critical.
Buildlogs are here:
https://redports.org/buildarchive/20120218193439-46853/

-jgh

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 5 Mark Linimon 2012-02-19 03:08:15 UTC
On Sat, Feb 18, 2012 at 06:36:13PM -0800, Jason Helfman wrote:
> Over to portmgr to address if issue is critical.

I can't comment on this part, but I prefer the following change not be made:

> -.if ${ARCH} == "ia64" || ${ARCH} == "powerpc" || ${ARCH} == "sparc64"
> -BROKEN=		Does not compile on ia64, powerpc, or sparc64
> -.endif
> +NOT_FOR_ARCHS= ia64 powerpc sparc64
> +NOT_FOR_ARCHS_REASON=		Does not compile on ia64, powerpc, or sparc64

since IIUC NOT_FOR_ARCHS is "has not yet been ported", not merely "fails
to compile".

mcl
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2012-02-19 03:12:47 UTC
On Sat, Feb 18, 2012 at 09:08:15PM -0600, Mark Linimon thus spake:
>On Sat, Feb 18, 2012 at 06:36:13PM -0800, Jason Helfman wrote:
>> Over to portmgr to address if issue is critical.
>
>I can't comment on this part, but I prefer the following change not be made:
>
>> -.if ${ARCH} == "ia64" || ${ARCH} == "powerpc" || ${ARCH} == "sparc64"
>> -BROKEN=		Does not compile on ia64, powerpc, or sparc64
>> -.endif
>> +NOT_FOR_ARCHS= ia64 powerpc sparc64
>> +NOT_FOR_ARCHS_REASON=		Does not compile on ia64, powerpc, or sparc64
>
>since IIUC NOT_FOR_ARCHS is "has not yet been ported", not merely "fails
>to compile".
>
>mcl
>

Will not commit that bit, and will await decision.

-jgh

-- 
Jason Helfman         | FreeBSD Committer
jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-02-20 23:49:19 UTC
jgh         2012-02-20 23:49:12 UTC

  FreeBSD ports repository

  Modified files:
    www/trafficserver    Makefile pkg-plist 
  Log:
  - don't clobber configs on upgrades
  
  PR:     ports/164740
  Submitted by:   jgh,rflynn@acsalaska.net
  Approved by:    maintainer timeout (17 days)
  
  Revision  Changes    Path
  1.21      +4 -1      ports/www/trafficserver/Makefile
  1.5       +70 -24    ports/www/trafficserver/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Jason Helfman freebsd_committer freebsd_triage 2012-02-20 23:49:33 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!