Bug 165006 - [patch] add missing dependencies to audio/audacity-devel
Summary: [patch] add missing dependencies to audio/audacity-devel
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-11 23:50 UTC by 4721@hushmail.com
Modified: 2012-02-25 22:28 UTC (History)
0 users

See Also:


Attachments
file.txt (3.77 KB, text/plain)
2012-02-11 23:50 UTC, 4721@hushmail.com
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description 4721@hushmail.com 2012-02-11 23:50:07 UTC
the ffmpeg, flac, ladspa, samplerate, and vorbis options were not hooked up to
*_DEPENDS, so they would only function if they happened to be already installed
on the system. (and add unrecorded dependencies). explicit *_DEPENDS have been
added to resolve this.

the libsamplerate option was actually controlling the libresample option, which
now correctly switches between audacity internal libresample and system
libsamplerate depending on the build option.

audacity also linked to libsamplerate and jack if installed, even if explicitly
disabled. they are now optionally patched out to stop this, which enables jack
to be a conditional dependency now.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-11 23:50:15 UTC
Maintainer of audio/audacity-devel,

Please note that PR ports/165006 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165006

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-11 23:50:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-02-25 22:12:38 UTC
eadler      2012-02-25 22:12:25 UTC

  FreeBSD ports repository

  Modified files:
    audio/audacity-devel Makefile 
  Log:
  - Add various depends to the appropriate OPTIONS
  - Fix up wording of options
  - misc. options improvements
  
  PR:             ports/165006
  Submitted by:   4721@hushmail.com
  Approved by:    maintainer timeout (2 weeks)
  
  Revision  Changes    Path
  1.58      +37 -9     ports/audio/audacity-devel/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2012-02-25 22:28:22 UTC
State Changed
From-To: feedback->closed

committed, thanks! 


Comment 5 Eitan Adler freebsd_committer freebsd_triage 2012-02-25 22:28:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

committed, thanks!