The @adds array is declared as a local variable in one place in smbldap-useradd.pl, and later its value is checked outside of its declaration scope. As a result just added Samba user will not get some Samba attributes. If this change goes to smbldap-tools port, then please do not forget about ports/161967. Fix: Apply this change to smbldap-tools sources or as a patch for the smbldap-tools port:
Responsible Changed From-To: freebsd-ports-bugs->mm Over to maintainer (via the GNATS Auto Assign Tool)
Please check if this does the job: http://svn.gna.org/viewcvs/smbldap-tools?view=revision&revision=124 http://svn.gna.org/viewcvs/smbldap-tools?view=revision&revision=125 Thanks -- Martin Matuska FreeBSD committer http://blog.vx.sk
On Wed, Feb 15, 2012 at 03:13:21PM +0100, Martin Matuska wrote: > Please check if this does the job: > http://svn.gna.org/viewcvs/smbldap-tools?view=revision&revision=124 > http://svn.gna.org/viewcvs/smbldap-tools?view=revision&revision=125 > I applied these changes to installed smbldap-tools's programs and looks like everything work as expected. I would prefer my change for smbldap-useradd.pl, but this is just a question of optimization and style.
mm 2012-02-17 13:46:47 UTC FreeBSD ports repository Modified files: net/smbldap-tools Makefile Added files: net/smbldap-tools/files patch-svn-123_125 Log: Add patch from vendor SVN. PR: ports/161967, ports/165177 Submitted by: Andrey Simonenko <simon at comsys.ntu-kpi.kiev.ua> Revision Changes Path 1.31 +1 -0 ports/net/smbldap-tools/Makefile 1.1 +35 -0 ports/net/smbldap-tools/files/patch-svn-123_125 (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Resolved. Thanks!