Bug 165197 - [patch] benchmarks/xdd: fix CPU detection slew of string.h compile time warnings
Summary: [patch] benchmarks/xdd: fix CPU detection slew of string.h compile time warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-16 07:30 UTC by Enji Cooper
Modified: 2013-02-03 22:30 UTC (History)
0 users

See Also:


Attachments
file.diff (5.48 KB, patch)
2012-02-16 07:30 UTC, Enji Cooper
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2012-02-16 07:30:11 UTC
The attached patch enhances xdd to detect the number of CPUs in a system (according to the semi-POSIX definition), and also fixes a slew of compile time warnings with string.h not being included in xdd.h.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-16 07:30:19 UTC
Maintainer of benchmarks/xdd,

Please note that PR ports/165197 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165197

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-16 07:30:23 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-04-15 12:28:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 4 Michael Scheidell freebsd_committer freebsd_triage 2012-04-15 12:40:48 UTC
maintainer:

We appreciate your time and efforts in helping with FreeBSD ports and 
porting.

submitters patch applies just fine, package builds in tinderbox in 
7-I386 - 9-AMD.
This pr has been opened for two months.  If you are not able to maintain 
benchmarks/xdd anymore, please let us know.

-- 
Michael Scheidell, CTO
 >*| * SECNAP Network Security Corporation
d: +1.561.948.2259
w: http://people.freebsd.org/~scheidell
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-04-15 12:43:27 UTC
scheidell    2012-04-15 11:43:13 UTC

  FreeBSD ports repository

  Modified files:
    benchmarks/xdd       Makefile 
    benchmarks/xdd/files patch-initialization.c patch-parse.c 
                         patch-xdd.h 
  Log:
  - Enhances detection of CPU count
  - fixes compile time warnings with string.hg not being included in xdd.h
  
  PR:             ports/165197
  Submitted by:   Garrett Cooper <yaneurabeya@gmail.com>
  Approved by:    g.gonter@ieee.org (maintainer, timeout 60 days)
  
  Revision  Changes    Path
  1.6       +1 -0      ports/benchmarks/xdd/Makefile
  1.4       +22 -9     ports/benchmarks/xdd/files/patch-initialization.c
  1.4       +29 -2     ports/benchmarks/xdd/files/patch-parse.c
  1.4       +16 -2     ports/benchmarks/xdd/files/patch-xdd.h
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Michael Scheidell freebsd_committer freebsd_triage 2012-04-15 12:43:29 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!