A bug in the pathname generation for category README.html files crept into the last version I submitted. This version should be the final release for a while now. It corrects the searching for ports when the top-level ports directory is not the standard "/usr/ports", and also makes the handling of the index file more robust, catching and reporting any errors in the index file, rather than crashing as before. Some minor tweaks to pathname handling (which is how this last bug got introduced), and minor edits of the template files. The pkg-message file is no longer needed, now that man page has been added, and should be deleted. Fix: Patch for latest version below. (Sorry about the screwup! It was late, and I had been working all day on this thing.) :-) How-To-Repeat: (Don't!) installed last version submitted. Category README.html files will be incorrectly generated as ${PORTSDIR}/${category}README.html (note the missing "/").
Responsible Changed From-To: freebsd-ports-bugs->jgh I'll take it.
Oh, good grief! Talk about your "comedy of errors". The last patch I submitted used an earlier version of the Makefile, before I had added the manpage to the package, and all I did was edit the VERSION line. Stupid! This is really quite embarrassing. But anyway, here's the final, *really* correct form of the port. Please accept my humble apologies. Conrad Index: Makefile =================================================================== RCS file: /home/ncvs/ports/ports-mgmt/mkreadmes/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- Makefile 4 Mar 2012 11:13:04 -0000 1.2 +++ Makefile 5 Mar 2012 17:22:14 -0000 @@ -6,7 +6,7 @@ # PORTNAME= mkreadmes -DISTVERSION= 1.0.2 +DISTVERSION= 1.1.1 CATEGORIES= ports-mgmt MASTER_SITES= SF MASTER_SITE_SUBDIR= ${PORTNAME} @@ -19,6 +19,9 @@ PLIST_FILES= sbin/${PORTNAME} PORTDATA= * +MAN1= mkreadmes.1 +MANCOMPRESSED= maybe + post-extract: # adjust definition of PREFIX in mkreadmes.h only if it differs from # the current setting of ${PREFIX} @@ -34,7 +37,4 @@ @${EGREP} -q 'default ${PREFIX}' ${WRKSRC}/main.c || \ ${REINPLACE_CMD} -e 's|/usr/local|${PREFIX}|' ${WRKSRC}/main.c -post-install: - @${CAT} pkg-message - .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /home/ncvs/ports/ports-mgmt/mkreadmes/distinfo,v retrieving revision 1.2 diff -u -r1.2 distinfo --- distinfo 4 Mar 2012 11:13:04 -0000 1.2 +++ distinfo 5 Mar 2012 17:20:24 -0000 @@ -1,2 +1,2 @@ -SHA256 (mkreadmes-1.0.2.tar.bz2) = 86adc7c419ef2f73b4f7fc890039d4a8c05afe05473bc64741a29941e5e9c264 -SIZE (mkreadmes-1.0.2.tar.bz2) = 14876 +SHA256 (mkreadmes-1.1.1.tar.bz2) = 6fade86f5c6466fedeb86c02e4a99053024664ce86794d57ca1a96d1a5429705 +SIZE (mkreadmes-1.1.1.tar.bz2) = 16692 Index: pkg-message =================================================================== RCS file: /home/ncvs/ports/ports-mgmt/mkreadmes/pkg-message,v retrieving revision 1.1 diff -u -r1.1 pkg-message --- pkg-message 3 Mar 2012 13:21:35 -0000 1.1 +++ pkg-message 5 Mar 2012 17:21:14 -0000 @@ -1,3 +0,0 @@ -For full description and usage information, see the file -"${PREFIX}/share/mkreadmes/README", or type "mkreadmes -h" -for help (sorry, no man page).
jgh 2012-03-05 17:50:47 UTC FreeBSD ports repository Modified files: ports-mgmt/mkreadmes Makefile distinfo Removed files: ports-mgmt/mkreadmes pkg-message Log: - Update to 1.1.1 - Bug fix release - Add man page PR: ports/165723 Submitted by: maintainer, conrads@cox.net Revision Changes Path 1.3 +3 -4 ports/ports-mgmt/mkreadmes/Makefile 1.3 +2 -2 ports/ports-mgmt/mkreadmes/distinfo 1.2 +0 -3 ports/ports-mgmt/mkreadmes/pkg-message (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!