New port: devel/p5-File-KeePass Interface to KeePass V1 datafile Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->perl perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Responsible Changed From-To: perl->culot I'll take it.
Hi Alexander, thanks for submitting this new port, however there are several problems with it. Here is a list of issues I found: - dependencies are wrong (one should use the vendor suggested dependencies, not the last version of the packages found in the ports tree) - some files are missing in plist - the license is missing - there are style issues (use of spaces instead of tabs in Makefile) You could use portlint(1) (available via ports-mgmt/portlint) to check your ports, and you could also run it via tinderbox (ports-mgmt/tinderbox) to check that it installs/deinstalls well. Those tools could help you spotting the kinds of issues mentionned above. I corrected those issues in the following updated port: http://people.freebsd.org/~culot/files/p5-File-KeePass.shar I also moved the port to the security category, as I believe it is more adequate (the devel category already has too many ports so if another category is more appropriate, go for it!). A tinderbox log corresponding to this updated port could be found here: http://people.freebsd.org/~culot/tinderbox/8.2-FreeBSD/p5-File-KeePass-0.03.log If you agree with those chances then I will import this updated port. Regards, Frederic
Hi Alexander, > > Hi Frederic, > > > > Sorry about that issues - it some kind of difficult to find a > > comprehensive guide about making FreeBSD port (I used Porters Handbook > > and ports\mk files, but looks like its not enough for me). I'll check about > > portlint and tinderbox more carefully than I did. no problem. There is indeed a lot of material and it's not easy to get a comprehensive view of everything that has to be checked when creating a new port! That's why committers are here to help so feel free to contact me directly if you need help next time you work on a port. > > I definitely agree with changes in port, expect one thing: it > > looks like that you remove p5-Digest-SHA1 from depencies list, but > > according to source code it is required thing (for example you may check MakeFile.pl > > of File-KeePass or File-KeePass itself). Will it work without it? > > Thanks, and sorry for my English - its not my native language. > > > > Regard, > > Alexander > > Sorry, my mistake. Its ok about p5-Digest-SHA1. Feel free to > import updated port. Thanks. Yes, Digest::SHA (and not Digest::SHA1) is now shipped as a perl core module (you could check that using corelist(1)) since perl 5.10. Hence I added the conditionnal to add this module in case the version of perl that is installed is lesser than 5.10. Again, feel free to contact me if you have any question. If you are on irc you could also join the #bsdports channel on efnet to get some help. Cheers, Frederic PS: I put bug-followup@ in CC so that the bug tracking system could keep track of your approval (emails are automatically inserted in the PR that way).
culot 2012-03-15 12:42:10 UTC FreeBSD ports repository Modified files: security Makefile Added files: security/p5-File-KeePass Makefile distinfo pkg-descr pkg-plist Log: File::KeePass is an interface to KeePassX and KeePass V1 database files. It supports only Rijndael encryption and only bases which were secured via passkeys (key files not supported). WWW: http://search.cpan.org/dist/File-KeePass/ PR: ports/165922 (based on) Submitted by: Alexander Y. Grigoryev <alexander.4mail@gmail.com> Feature safe: yes Revision Changes Path 1.1262 +1 -0 ports/security/Makefile 1.1 +33 -0 ports/security/p5-File-KeePass/Makefile (new) 1.1 +2 -0 ports/security/p5-File-KeePass/distinfo (new) 1.1 +5 -0 ports/security/p5-File-KeePass/pkg-descr (new) 1.1 +5 -0 ports/security/p5-File-KeePass/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed New port added. Thanks Alexander!
culot 2012-03-15 12:49:10 UTC FreeBSD doc repository (ports committer) Modified files: en_US.ISO8859-1/articles/contributors contrib.additional.sgml Log: Add Alexander Grigoryev <alexander.4mail@gmail.com> for security/p5-File-KeePass. PR: ports/165922 Revision Changes Path 1.1071 +5 -0 doc/en_US.ISO8859-1/articles/contributors/contrib.additional.sgml _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"