On 06 Mar 2012 sysutils/mount.app was Marked BROKEN because it does not compile with x11-wm/windowmaker 0.95 (that is true) Fix: The problem lies here, i think : http://lists.windowmaker.org/dev/msg00985.html where the function 'WMWritePropListToFile' was simplified and no longer wait for a third entry. I generated a patch (included) applied it, and then successfully builded, installed and run the application; on both 9.0-STABLE and 8.3 PRERELEASE stations. (i386 and AMD64) If it is a correct approch, could you please include the patch and fix the port entry? Thanks for your time. Martin MATO Patch attached with submission follows: How-To-Repeat: to have a brief review of the problem; Untag BROKEN entry in sysutils/mount.app/Makefile make and then the failure appears: Making all in EXTRAS cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include -O2 -pipe -fno-strict-aliasing -std=gnu89 -I/usr/local/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/local/include -DUSE_XPM -c `test -f 'mount.c' || echo './'`mount.c cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include -O2 -pipe -fno-strict-aliasing -std=gnu89 -I/usr/local/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/local/include -DUSE_XPM -c `test -f 'fstab.c' || echo './'`fstab.c cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include -O2 -pipe -fno-strict-aliasing -std=gnu89 -I/usr/local/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/local/include -DUSE_XPM -c `test -f 'properties.c' || echo './'`properties.c properties.c: In function 'saveProperties': properties.c:451: error: too many arguments to function 'WMWritePropListToFile' *** Error code 1 Stop in /usr/ports/sysutils/mount.app/work/mountapp-3.0/src. *** Error code 1
Maintainer of sysutils/mount.app, Please note that PR ports/166176 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166176 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Seems good to me. On 03/16/2012 01:20 PM, Edwin Groothuis wrote: > Maintainer of sysutils/mount.app, > > Please note that PR ports/166176 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166176 >
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->feedback Patched, compiles now. Have a question about BUILD_DEPENDS+=. Two really. It seems to reference a library, so you really only need this to build? if you remove the library will this run? Second is in the +=. Minor porint, but should this not just be =?
scheidell 2012-03-27 23:02:42 UTC FreeBSD ports repository Modified files: sysutils/mount.app Makefile Added files: sysutils/mount.app/files patch-properties.c Log: - Unbreak build - No PORTREVISION bump PR: ports/166176 Submitted by: Martin MATO <martin.mato@orange.fr> Approved by: Gaspar Chilingarov <nm@web.am> (maintainer) Feature safe: yes Revision Changes Path 1.15 +2 -4 ports/sysutils/mount.app/Makefile 1.1 +11 -0 ports/sysutils/mount.app/files/patch-properties.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!