Bug 166319 - [PATCH] games/bsdgames: battlestar needs fixing
Summary: [PATCH] games/bsdgames: battlestar needs fixing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ulrich Spörlein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 14:40 UTC by Marco Steinbach
Modified: 2012-05-25 12:00 UTC (History)
0 users

See Also:


Attachments
file.shar (25.61 KB, text/plain)
2012-03-22 14:40 UTC, Marco Steinbach
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Steinbach 2012-03-22 14:40:12 UTC
*BATTLESTAR NEWSFLASH*BATTLESTAR NEWSFLASH*BATTLESTAR NEWSFLASH*

Battlestar Daily uncovers heinous sabotage scheme !
Leaked mission radio protocols show losing grip on reality.

In what flabbergasted experts describe as a 'highly efficient, covert thingie'-scheme, members of our forces involved in highly classified operations suffered a dramatic loss of vital sensorical capabilities, leading to desastrous results.

From leaked radio recordings and its own sources involved in mission preparation and conduct, BD learned shocking details of failed missions.

While sources insist, that missions parameters were in normal range at all times, the recordings reveal disoriented operatives, sobbingly crawling floors looking for gear like laser pistols, or panicking over loss of visuals after battles in space.

'Odd.', one expert is quoted saying after reviewing detailed mission protocols, clearly admitting to this being a deliberate act of sabotage.

'They need to adapt to this new threat.', says Vidad Gleirg, Battlestar senior consultant with Anagram & Partners, 'Quickly.'.

BD has notified officials of the situation, and is awaiting responses.

Fix: battlestar lets setbit in sys/param.h override its own, different implementation, leading to all sorts of odd behaviour.  I've renamed battlestars setbit to bsetbit in this patch.

Also, won space fights do no longer end in darkness, as this patch sets buffering back to linemode afterwards.

I've tested the attached, patched port on i386 and amd64, and it works for me.


Patch attached with submission follows:
How-To-Repeat: Start battlestar, go right, go left.  There should be a laser pistol, but it's missing.

Start battlestar, launch from the battlestar, pick a space fight, win it, and be left in total darkness.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-22 16:07:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->uqs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-05-25 11:50:22 UTC
uqs         2012-05-25 10:50:07 UTC

  FreeBSD ports repository

  Modified files:
    games/bsdgames       Makefile 
  Added files:
    games/bsdgames/files patch-battlestar 
  Log:
  Fix battlestar(6), there was treachery afoot, see the newsflash.
  
  *BATTLESTAR NEWSFLASH*BATTLESTAR NEWSFLASH*BATTLESTAR NEWSFLASH*
  
  Battlestar Daily uncovers heinous sabotage scheme!
  Leaked mission radio protocols show losing grip on reality.
  
  In what flabbergasted experts describe as a 'highly efficient, covert
  thingie'-scheme, members of our forces involved in highly classified operations
  suffered a dramatic loss of vital sensorical capabilities, leading to
  desastrous results.
  
  From leaked radio recordings and its own sources involved in mission
  preparation and conduct, BD learned shocking details of failed missions.
  
  While sources insist, that missions parameters were in normal range at all
  times, the recordings reveal disoriented operatives, sobbingly crawling floors
  looking for gear like laser pistols, or panicking over loss of visuals after
  battles in space.
  
  'Odd.', one expert is quoted saying after reviewing detailed mission protocols,
  clearly admitting to this being a deliberate act of sabotage.
  
  'They need to adapt to this new threat.', says Vidad Gleirg, Battlestar senior
  consultant with Anagram & Partners, 'Quickly.'.
  
  BD has notified officials of the situation, and is awaiting responses.
  
  PR:             ports/166319
  Submitted by:   Marco Steinbach <coco@executive-computing.de>
  Approved by:    beat (mentor)
  
  Revision  Changes    Path
  1.30      +1 -1      ports/games/bsdgames/Makefile
  1.1       +34 -0     ports/games/bsdgames/files/patch-battlestar (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Ulrich Spörlein freebsd_committer freebsd_triage 2012-05-25 11:52:09 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!