Bug 166614 - [PATCH] emulators/virtualbox-ose: VBoxAuthPAM.c references non-existent pam.so.0
Summary: [PATCH] emulators/virtualbox-ose: VBoxAuthPAM.c references non-existent pam.so.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 18:00 UTC by Landon Fuller
Modified: 2012-04-13 22:51 UTC (History)
0 users

See Also:


Attachments
file.diff (410 bytes, patch)
2012-04-03 18:00 UTC, Landon Fuller
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Landon Fuller 2012-04-03 18:00:09 UTC
The VBoxAuthPAM.c implementation attempts to dlopen() PAM, but uses the
non-existent "pam.so.0" path. Attached is a small patch to be included
with the port -- it simply uses "pam.so" when defined(RT_OS_FREEBSD).

Test result without fix (using VBOX_AUTH_DEBUG_FILENAME):

u[vboxusers], d[(null)], p[40]
auth_pam_init: dlopen libpam.so.0 failed
auth_pam_init failed 4

Test after fix:

u[vboxusers], d[(null)], p[40]
init ok
Using PAM service: login
start ok
auth ok
access granted
auth_pam_close completed

Fix: Apply the provided patch to the port.

Patch attached with submission follows:
How-To-Repeat: Attempt to authenticate against a virtualbox service, such as vboxwebsrv.
PAM-based authentication will fail.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-04-05 02:37:57 UTC
State Changed
From-To: open->feedback

to which port does this patch apply?
Comment 2 Landon Fuller 2012-04-05 02:51:23 UTC
An amusing oversight, apologies. Applies to emulators/virtualbox-ose
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2012-04-05 07:01:12 UTC
State Changed
From-To: feedback->open

feedback received.
Comment 4 Bernhard Froehlich freebsd_committer freebsd_triage 2012-04-05 10:01:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vbox

Over to maintainer
Comment 5 Bernhard Froehlich freebsd_committer freebsd_triage 2012-04-05 11:48:06 UTC
Thanks for the patch! It looks fine to me so I will include
it in the next port update.

Do you agree that this patch is under MIT License so that I
can submit it upstream?

-- 
Bernhard Fröhlich
http://www.bluelife.at/
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-04-05 12:17:13 UTC
decke       2012-04-05 11:16:31 UTC

  FreeBSD ports repository

  Modified files:
    emulators/virtualbox-ose Makefile distinfo 
    emulators/virtualbox-ose-additions Makefile distinfo 
    emulators/virtualbox-ose-kmod Makefile distinfo 
  Added files:
    emulators/virtualbox-ose/files 
                                   patch-src-VBox-HostServices-auth-pam-VBoxAuthPAM.c 
  Log:
  - Update to 4.1.12
  - Fix PAM authentication for vboxwebsrv  [1]
  
  PR:             ports/166614 [1]
  Submitted by:   Landon Fuller <landonf@plausible.coop> [1]
  Feature safe:   yes
  
  Revision  Changes    Path
  1.20      +1 -1      ports/emulators/virtualbox-ose-additions/Makefile
  1.14      +2 -2      ports/emulators/virtualbox-ose-additions/distinfo
  1.41      +1 -1      ports/emulators/virtualbox-ose-kmod/Makefile
  1.23      +2 -2      ports/emulators/virtualbox-ose-kmod/distinfo
  1.48      +1 -1      ports/emulators/virtualbox-ose/Makefile
  1.23      +4 -4      ports/emulators/virtualbox-ose/distinfo
  1.1       +11 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-HostServices-auth-pam-VBoxAuthPAM.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Landon Fuller 2012-04-05 14:53:24 UTC
Sure -- Please consider it MIT licensed, under the copyright of my
company ( Plausible Labs Cooperative, Inc. ).
Comment 8 Bernhard Froehlich freebsd_committer freebsd_triage 2012-04-13 22:51:04 UTC
State Changed
From-To: open->closed

Committed. Thanks!