Bug 166719 - [MAINTAINER] lang/gnatdroid-armv5: upgrade to sync with gcc 4.6.3
Summary: [MAINTAINER] lang/gnatdroid-armv5: upgrade to sync with gcc 4.6.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frederic Culot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-07 13:10 UTC by John Marino
Modified: 2012-04-23 15:30 UTC (History)
0 users

See Also:


Attachments
file.diff (14.15 KB, patch)
2012-04-07 13:10 UTC, John Marino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2012-04-07 13:10:05 UTC
NOTE: Depends on ports/166718 so that PR must be closed before this one.

This patch converts lang/gnatdroid-armv5 from a custom-built standalone port to one that is based on lang/gnat-aux which uses official gcc tarballs.

In addition, it has been upgraded to provide options to add Objective-C and Fortran languages.  The C and Ada languages are still built by default.

Note that every patch in the "files" directory as been deleted, so the directory itself can be removed.

Fix: Patch attached with submission follows:
Comment 1 Frederic Culot freebsd_committer freebsd_triage 2012-04-07 15:41:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->culot

I'll take it.
Comment 2 Frederic Culot freebsd_committer freebsd_triage 2012-04-23 07:49:12 UTC
Hi John,

I have committed your update for gnat-aux and I am currently working on
gnatdroid-arm* updates but I wanted to make sure of something: when I apply your
patch I get all the patches in files/* emptied. Is it what is expected or is
there something wrong with the patch?

I noticed for example that some of the files were not present in your new
working repository:

--- files/patch-gcc__ada__gccint__Makefile.in   2011-09-10 19:53:10.000000000 +0200
+++ /dev/null   2012-04-07 12:11:00.000000000 +0200

while others were but emptied:

---- libiberty/setproctitle.c.orig      2011-01-29 07:11:03 +0100
-+++ libiberty/setproctitle.c           2011-01-29 07:28:55 +0100
-@@ -40,9 +40,11 @@
- void
- setproctitle (const char *name ATTRIBUTE_UNUSED, ...)
- {
-+#ifndef __ANDROID__
- #ifdef PR_SET_NAME
-   /* On Linux this sets the top visible "comm", but not necessarily
-      the name visible in ps. */
-   prctl (PR_SET_NAME, name);
- #endif
-+#endif
- }


Hence I am not sure of why such a difference and wanted to check with you before
taking any action.

Cheers,
Frederic
Comment 3 Frederic Culot freebsd_committer freebsd_triage 2012-04-23 07:51:44 UTC
State Changed
From-To: open->feedback

Ask for maintainer clarification.
Comment 4 John Marino 2012-04-23 14:02:13 UTC
On 4/23/2012 08:49, Frederic Culot wrote:
> Hi John,
>
> I have committed your update for gnat-aux and I am currently working on
> gnatdroid-arm* updates but I wanted to make sure of something: when I apply your
> patch I get all the patches in files/* emptied. Is it what is expected or is
> there something wrong with the patch?

Hi Frederic,
Yes, that is expected.  It's even listed in the description of 
ports/166719: "Note that every patch in the "files" directory as been 
deleted, so the directory itself can be removed."

So if applying the PR patch results in an empty files directory, it's 
behaving exactly as expected.  The next gnat-aux now has these patches 
by default which is why it had to be updated before this PR.

Regards,
John
Comment 5 Frederic Culot freebsd_committer freebsd_triage 2012-04-23 14:37:04 UTC
Oops, sorry John! Somehow I overlooked this sentence in your original
submission.

Thanks for the clarification and sorry again for the noise.
Frederic
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-04-23 15:27:36 UTC
culot       2012-04-23 14:27:21 UTC

  FreeBSD ports repository

  Modified files:
    lang/gnatdroid-armv5 Makefile distinfo pkg-plist 
  Removed files:
    lang/gnatdroid-armv5/files patch-configure 
                               patch-gcc__Makefile.in 
                               patch-gcc__ada__adaint.c 
                               patch-gcc__ada__gccint__Makefile.in 
                               patch-libiberty__getpagesize.c 
                               patch-libiberty__setprotitle.c 
  Log:
  - Update to 20120301 (corresponding to gcc 4.6.3)
  
  PR:             ports/166719
  Submitted by:   John Marino <draco@marino.st> (maintainer)
  
  Revision  Changes    Path
  1.3       +83 -23    ports/lang/gnatdroid-armv5/Makefile
  1.2       +12 -2     ports/lang/gnatdroid-armv5/distinfo
  1.2       +0 -11     ports/lang/gnatdroid-armv5/files/patch-configure (dead)
  1.2       +0 -27     ports/lang/gnatdroid-armv5/files/patch-gcc__Makefile.in (dead)
  1.2       +0 -50     ports/lang/gnatdroid-armv5/files/patch-gcc__ada__adaint.c (dead)
  1.2       +0 -83     ports/lang/gnatdroid-armv5/files/patch-gcc__ada__gccint__Makefile.in (dead)
  1.2       +0 -15     ports/lang/gnatdroid-armv5/files/patch-libiberty__getpagesize.c (dead)
  1.2       +0 -14     ports/lang/gnatdroid-armv5/files/patch-libiberty__setprotitle.c (dead)
  1.2       +5 -7      ports/lang/gnatdroid-armv5/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Frederic Culot freebsd_committer freebsd_triage 2012-04-23 15:27:51 UTC
State Changed
From-To: feedback->closed

Committed. Thanks John!