Bug 166729 - multimedia/ogmtools should use the OPTIONS framework
Summary: multimedia/ogmtools should use the OPTIONS framework
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-07 15:40 UTC by Thomas Zander
Modified: 2012-04-11 17:30 UTC (History)
0 users

See Also:

Attachments
file.diff (728 bytes, patch)
2012-04-07 15:40 UTC, Thomas Zander 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander 2012-04-07 15:40:05 UTC 
ogmtools still performs opportunistic detection of locally installed packages to determine its dependencies.
This is discouraged nowadays since the OPTIONS framework expects the user to explicitly state what he wants.

Fix: Attached patch introduces OPTIONS for the (so far) only dependency variable WITH_DVDREAD.

Patch attached with submission follows:
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2012-04-07 21:24:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-04-11 17:24:29 UTC 
jgh         2012-04-11 16:24:16 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/ogmtools  Makefile 
  Log:
  - move to options framework for dvdread
  - bump PORTREVISION
  
  PR:     ports/166729
  Submitted by:   thomas.e.zander@googlemail.com
  Approved by:    kwm (multimedia@)
  
  Revision  Changes    Path
  1.32      +2 -9      ports/multimedia/ogmtools/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2012-04-11 17:24:33 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!