- Unbreak port on FreeBSD 9 by updating it to 3.0.0 Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->feedback Thank you for your continued support of FreeBSD. I was about to commit this update for you, and noticed a couple of things. First, not all that important. the .if ${ARCH}, could be converted to NOT_FOR_ARCHS/(REASON) Second, this installs shared libraries, needs proper use of LDCONFIG Third, it looks like you did a 'copy/paste' on this patch, and it did not preserve the <tab>s. Could you run portlint -abt on the final of this, and upload a new patch as an attachment?
Here is a corrected patch -- Mikhail
Question: sorry I didn't notice this before. is this a master or slave port? I noticed this in an odd location in the Makefile: OPTIONS+= MYSQL "MySQL database support" on \ SQLITE3 "SQLite 3.x database support" on \ FIREBIRD "Firebird (Interbase) database support" on \ PGSQL "PostgreSQL database support" on (the location is a little odd, and the += is a little odd) -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
No joy: Still broken on 9.x: You might want to join freebsd-ports mailing list and specifically ask about changes to (missing utmp.h) and utmp functions. You also might want to search GNATS (pr database, support database) for closed pr's that have dealt with this. <http://lorie.secnap.net/tb/index.php?action=display_markup_log&build=9-scheidell_AMD64&id=1559#839> <http://lorie.secnap.net/tb/index.php?action=display_markup_log&build=9-scheidell_I386&id=1559#852> gcc -I. -I../../../../../include -W -Wall -O3 -DHB_LEGACY_TYPES_OFF -fPIC -oucmacice.o -c ../../../ucmacice.c 852 In file included from ../../../gtcrs.c:56: 853 ../../../gtcrs.h:105:40: error: utmp.h: No such file or directory I see this in your Makefile: > .if defined(CC)&& ${CC} == "clang" > +HB_COMPILER= clang > +.else > +HB_COMPILER= gcc > +USE_GCC= 4.2+ > +.endif > did you define CC in your env? or make.conf to get this to compile? We need those defines in your Makefile so that an OP doesn't have to put custom defines in their make.conf (and FreeBSD build clusters won't either) Do you have a tinderbox? can you join redports and test his out on redports? I can still commit the upgrade to 3.0, but will need to leave in the BROKEN part. Your choice. Also, I have a 'nicer' Makefile for you to look at. Puts some of the sections in more standard places (NOT_FOR_ARCH/ OPTIONS near top where people normally look for them). Also re-wrapped the .if !defined NOPORTDOCS, and will work on that later. my tinderbox has 7.4 and 8.2, and they compile just fine. my test box is 9.x, so I can't really test this fully. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
> .if defined(CC)&& ${CC} == "clang" > +HB_COMPILER= clang > +.else > +HB_COMPILER= gcc > +USE_GCC= 4.2+ > +.endif I have removed these lines and created an option for CLANG (like www/chromium does) instead them. NOT_FOR_ARCHS is placed just after *_DEPENDS section now. Also conditionally changing utmp.h to utmpx.h on freebsd9 was enough to build the port. I just compiled it successfully under 9.0 tinderbox. But I did't understand what should I do with NOPORTDOCS. Here is updated patch. -- Mikhail
On 4/11/12 8:30 PM, Mikhail Tsatsenko wrote: > But I did't understand what should I do with NOPORTDOCS. > I am looking at it now. everything compiles now with defaults in 7,8,9, i386,amd64. but... if you do a 'make -DNOPORTDOCS install' it installs the portdocs anyway. I am looking into it. Might need to patch wksrc/Makefile.* or ../config/* files. If you get it figured out before I do, send me what you have. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
I found the problem. There is no patching required. We need just to catch up with upstream variable change in our Makefile. See attached patch.
I moved things around a little, but don't think I changed the intent. portmgr, system operators and users like to see 'options' at the top, the intent is that quickly they can see what options exist, what arch's you support, what happens with portdocs, etc. I have tried this in tinderbox, and it seems to do what we both want it to, just in a slightly different order. I have more more pass at tinderbox, and then I will commit this pr unless I find anything else. Thanks again for your efforts. -- Michael Scheidell, CTO SECNAP Network Security Corporation http://people.freebsd.org/~scheidell ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.spammertrap.com/ ______________________________________________________________________
ps, you don't need this: .if !defined(NOPORTDOCS) @${MKDIR} ${DOCSDIR} .endif PORTDOCS macro in /usr/ports/Mk/*options?) takes care of the mkdir. -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
Always test in tinderbox :-) my new makefile, MAKE_ENV= HB_ARCHITECTURE=${HB_ARCH} \ needed to be MAKE_ENV+= HB_ARCHITECTURE=${HB_ARCH} \ -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
scheidell 2012-04-14 13:25:07 UTC FreeBSD ports repository Modified files: lang/harbour Makefile distinfo pkg-plist Log: - Update to 3.0.0 [1] - Unbreak port on FreeBSD 9 [1] - Minor re-arrangement of Makefile for clarity [2] PR: ports/166754 [1] Submitted by: Mikhail T <m.tsatsenko@gmail.com> (maintainer) [1] Reviewed by: scheidell (me) [2] Revision Changes Path 1.24 +98 -19 ports/lang/harbour/Makefile 1.7 +2 -2 ports/lang/harbour/distinfo 1.6 +295 -221 ports/lang/harbour/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!