zathura is a highly customizable and functional PDF viewer based on the poppler rendering library and the gtk+ toolkit. The idea behind zathura is an application that provides a minimalistic and space saving interface as well as an easy usage that mainly focuses on keyboard interaction. Fix: Patch attached with submission follows:
Maintainer of graphics/zathura, Please note that PR ports/167330 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167330 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
There are two problems with this patch: 1. it depends on the girara ports in PR ports/167328, which is wrong for the moment (it installs the lib files in /usr/lib instead of /usr/local/lib, this can be fixed by setting LIBDIR to /usr/local/lib in the Makefile) 2. because of the behavior of RUN_DEPENDS, it does *not* install the plugins if the directory /usr/local/lib/zathura/ which is likely the case if this is the first time the port is built 2012/4/26 Edwin Groothuis <edwin@freebsd.org>: > Maintainer of graphics/zathura, > > Please note that PR ports/167330 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/167330 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
I fixed the submitter's patch, since I don't have any news from him for almost a month. The patch is attached. Note that this patch should not be commited before PR ports/167328, because it depends on girara which is added in this PR. Fixes are: - A lot of things were missing from the pkg-plist - Added the WITHOUT_NLS knob support - Fixes the NOPORTDOCS knob support - Print a message to notify the user that he should install at least one plugin to view documents - Fixes paths in zathura.pc file
Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
pawel 2012-05-18 20:11:35 UTC FreeBSD ports repository Modified files: graphics/zathura Makefile distinfo Added files: graphics/zathura pkg-message pkg-plist graphics/zathura/files patch-document.c Log: - Update to version 0.1.2 - Support WITHOUT_NLS - Add pkg-message - Switch to pkg-plist PR: ports/167330 Submitted by: Mihail Krutov <neko@takino.org> Approved by: maintainer (with his fixes) Revision Changes Path 1.11 +29 -23 ports/graphics/zathura/Makefile 1.6 +2 -2 ports/graphics/zathura/distinfo 1.1 +10 -0 ports/graphics/zathura/files/patch-document.c (new) 1.1 +8 -0 ports/graphics/zathura/pkg-message (new) 1.1 +10 -0 ports/graphics/zathura/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!