devel/libytnef/ytnef.c has incomplete handling of the PT_CLSID type and will spin off and crash applications attempting to use it. Patch attached properly handles the GUID data structure via hardcoded magic values. Fix ideas were liberally stolen from the MSDN docs and wine.org handling code.
Patch located at: http://people.freebsd.org/~sbruno/libytnef_ytnef_c.txt Sean
Responsible Changed From-To: freebsd-bugs->freebsd-ports-bugs ports PR.
Responsible Changed From-To: freebsd-ports-bugs->sbruno Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of devel/libytnef, Please note that PR ports/167460 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167460 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I'm almost 100% positive that this library is dead upstream. http://ytnef.sourceforge.net/ Last update was 2004-09-14 according to sourceforge. I think its completely reasonable to patch our port of this and move on. Sean
Responsible Changed From-To: sbruno->tabthorpe I'll take it.
tabthorpe 2012-05-28 19:28:38 UTC FreeBSD ports repository Modified files: devel/libytnef Makefile Added files: devel/libytnef/files patch-ytnef.c Log: - Fix handling of T_CLSID in TNEFFillMapi - Bump PORTREVISION PR: ports/167460 Submitted by: sbruno@ Approved by: maintainer timeout Revision Changes Path 1.9 +1 -1 ports/devel/libytnef/Makefile 1.1 +25 -0 ports/devel/libytnef/files/patch-ytnef.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!